TracedToTypes fixes #1306
Open
TracedToTypes fixes #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
reviewed
May 21, 2025
src/Tracing.jl
Outdated
| if mode == TracedToTypes | ||
| return nothing | ||
| end | ||
| # TODO: does anything more need to be done here? |
There was a problem hiding this comment.
I feel like we should consider this similarly to how we handle arrays?
There was a problem hiding this comment.
Honestly I'm not sure at what point I needed this and I think we can do without, I've removed it.
|
I think CI failure is just flaky aarch64? |
wsmoses
force-pushed
the
jm/tracedtotypes
branch
from
b3bc748 to
18cad7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered the make_tracer on
Memoryduring function call insertion development, I'm not entirely sure it's still needed so if wanted I can split it off from this and test better.