Skip to content

Fix for issue 189: Tour will no longer overflow left edge of view #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for issue 189: Tour will no longer overflow left edge of view #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/trip.core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,6 +992,9 @@ Trip.prototype = {
case 's':
cssHorizontal += $sel.offset().left + ((selWidth - blockWidth) / 2);
cssVertical += $sel.offset().top + selHeight + arrowHeight;
if (cssHorizontal < 0) {
cssHorizontal = 0;
}
break;
case 'w':
cssHorizontal += $sel.offset().left - (arrowWidth + blockWidth);
Expand All @@ -1002,10 +1005,30 @@ Trip.prototype = {
default:
cssHorizontal += $sel.offset().left + ((selWidth - blockWidth) / 2);
cssVertical += $sel.offset().top - arrowHeight - blockHeight;
if (cssHorizontal < 0) {
cssHorizontal = 0;
}
break;
}

if (horizontalOrVertical === 'horizontal') {
// When the sel element is close to the page edge and the tripBlock has a modified (not centered) horizontal
// position we also modify the horizontal position of the arrow.
// Because the arrow is a pseudo element we cannot select it directly with jQuery
// so we create a style tag which we can then manipulate.
if (cssHorizontal <= 0) {
// add a style tag if it doesn't already exist in the DOM tree
if (typeof $('#arrowstyle').get(0) === 'undefined') {
$('head').append('<style id="arrowstyle"></style>');
}
// set the arrow to an appropriate horizontal location
$('#arrowstyle').text('.trip-block.n::before,.trip-block.s::before{left:' + ($sel.offset().left + (selWidth / 2) - arrowWidth) + 'px !important;}');
}
else {
// use default arrow horizontal location
$('#arrowstyle').remove();
}

switch (o.position) {
case 'screen-center':
$tripBlock.css({
Expand Down