-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Switch to configuration based events on Paper #6248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.x
Are you sure you want to change the base?
Conversation
Not sure if this is out of scope for this PR; however, the PlayerLoginEvent is now considered deprecated on newer versions of Paper. Maybe the AsyncPlayerPreLoginEvent should be used instead? |
this pr moves us away from the PlayerLoginEvent on paper :)) |
Ah yeah, must’ve misread. I saw the event still used elsewhere without realizing that it was intended for Spigot |
# Conflicts: # Essentials/src/main/java/com/earth2me/essentials/perm/impl/LuckPermsHandler.java
Moves away from PlayerLoginEvent on Paper and makes use of the new configuration state to load user/locale data during configuration phase. Not only does this ensure all I/O is done async before the player even joins but also finally allows us to actually set the join message in the PlayerJoinEvent.
This also fixes #5796 and closes #5848