Skip to content

Fix server freezing with /give #6449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JRoy merged 2 commits into from
Feb 28, 2026
+10 −2
Merged

Fix server freezing with /give #6449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c73ec88
Fix server freezing with /give <player> written_book
UDPSendToFailed Feb 28, 2026
20d6a9e
Merge branch '2.x' into 2.x
mdcfe Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Essentials/src/main/java/com/earth2me/essentials/MetaItemStack.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,8 +308,14 @@ public void addStringMeta(final CommandSource sender, final boolean allowUnsafe,
final BookMeta meta = (BookMeta) stack.getItemMeta();
meta.setTitle(title);
stack.setItemMeta(meta);
} else if (split.length > 1 && split[0].startsWith("page") && split[0].length() > 4 && MaterialUtil.isEditableBook(stack.getType()) && hasMetaPermission(sender, "page", false, true, ess)) {
final int page = NumberUtil.isInt(split[0].substring(4)) ? (Integer.parseInt(split[0].substring(4)) - 1) : 0;
} else if (split.length > 1 && split[0].startsWith("page") && split[0].length() > 4
&& MaterialUtil.isEditableBook(stack.getType())
&& hasMetaPermission(sender, "page", false, true, ess)) {
final int page = NumberUtil.isInt(split[0].substring(4)) ? (Integer.parseInt(split[0].substring(4)) - 1)
: 0;
if (page > 100) {
throw new TranslatableException("pageLimitExceeded");
}
final BookMeta meta = (BookMeta) stack.getItemMeta();
final List<String> pages = meta.hasPages() ? new ArrayList<>(meta.getPages()) : new ArrayList<>();
final List<String> lines = new ArrayList<>();
Expand Down
1 change: 1 addition & 0 deletions Essentials/src/main/resources/messages.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,6 +909,7 @@ openingDisposal=<primary>Opening disposal menu...
orderBalances=<primary>Ordering balances of<secondary> {0} <primary>users, please wait...
oversizedMute=<dark_red>You may not mute a player for this period of time.
oversizedTempban=<dark_red>You may not ban a player for this period of time.
pageLimitExceeded=<dark_red>Page number exceeds the maximum limit (100).
passengerTeleportFail=<dark_red>You cannot be teleported while carrying passengers.
payCommandDescription=Pays another player from your balance.
payCommandUsage=/<command> <player> <amount>
Expand Down
1 change: 1 addition & 0 deletions Essentials/src/main/resources/messages_en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,6 +904,7 @@ openingDisposal=<primary>Opening disposal menu...
orderBalances=<primary>Ordering balances of<secondary> {0} <primary>users, please wait...
oversizedMute=<dark_red>You may not mute a player for this period of time.
oversizedTempban=<dark_red>You may not ban a player for this period of time.
pageLimitExceeded=<dark_red>Page number exceeds the maximum limit (100).
passengerTeleportFail=<dark_red>You cannot be teleported while carrying passengers.
payCommandDescription=Pays another player from your balance.
payCommandUsage=/<command> <player> <amount>
Expand Down
Loading