Changes from Lyon #26
Conversation
jerjohste
commented
Feb 26, 2021
jerjohste
commented
- Addition of new pulse shapes (gaussian and tanh).
- Addition of a pulse sequence viewer to check sequence code will work
- Addition of pulse loop transfer feature
MatthieuDartiailh
left a comment
MatthieuDartiailh
left a comment
There was a problem hiding this comment.
I gave this a quick read. May try to make a more thorough review later
| @@ -0,0 +1,86 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # ----------------------------------------------------------------------------- | |||
| # Copyright 2015-2018 by ExopyPulses Authors, see AUTHORS for more details. | |||
There was a problem hiding this comment.
the copyright does not make sense, I would expect to see 2021
| """ | ||
| #: Amplitude of the pulse this should be a number between -1.0 and 1.0 | ||
| amplitude = Str('1.0').tag(pref=True, feval=Feval(types=Real)) | ||
| sigma = Str('10.0').tag(pref=True, feval=Feval(types=Real)) |
There was a problem hiding this comment.
ideally a comment for sigma too
| @@ -0,0 +1,88 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # ----------------------------------------------------------------------------- | |||
| # Copyright 2015-2018 by ExopyPulses Authors, see AUTHORS for more details. | |||
| """ | ||
| #: Amplitude of the pulse this should be a number between -1.0 and 1.0 | ||
| amplitude = Str('1.0').tag(pref=True, feval=Feval(types=Real)) | ||
| sigma = Str('10.0').tag(pref=True, feval=Feval(types=Real)) |
| @@ -0,0 +1,42 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # ----------------------------------------------------------------------------- | |||
| # Copyright 2015-2018 by ExopyPulses Authors, see AUTHORS for more details. | |||
| sequence_vars = Typed(OrderedDict, ()).tag(pref=(ordered_dict_to_pref, | ||
| ordered_dict_from_pref)) | ||
|
|
||
There was a problem hiding this comment.
please strip spaces when saving
|
|
||
| channel_num = len(table) | ||
| #fig, axs = plt.subplots(4,1, figsize=(15, 8)) | ||
| fig, axs = plt.subplots(channel_num,1, figsize=(15, 2.5*channel_num), |
There was a problem hiding this comment.
using constrained_layout makes generally for nicer plots
| for k, v in infos.items(): | ||
| self.write_in_database(k, v) | ||
|
|
||
| def compile_and_plot(self, variables): |
There was a problem hiding this comment.
I am not sure this belongs on the task. I feel like it would be better on the plugin.
|
|
||
| database_entries = set_default({'num_loop': 1}) | ||
|
|
||
| # def check(self, *args, **kwargs): |
There was a problem hiding this comment.
Why are no checks actually done ?
|
|
||
| class TransferPulseLoopTask(InstrumentTask): | ||
| """Build and transfer a pulse sequence to an instrument. | ||
There was a problem hiding this comment.
Since this make several several hypothesis on the driver it could be nice to list them.
|
Superseded by #27 |
2 participants
