Enable prefer-array-find unicorn eslint rule #163

NJ-2020 · 2025-10-19T04:17:31Z

Explanation of Change

Enforce that .find is being used instead of .filter when matching one/1 element, and enforce to use .findLast when trying to match the last element

$: Expensify/App#67423

PROPOSAL: Expensify/App#67423 (comment)

github-actions · 2025-10-19T04:17:48Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

NJ-2020 · 2025-10-19T04:18:31Z

I have read the CLA Document and I hereby sign the CLA

NJ-2020 · 2025-10-19T04:18:38Z

recheck

rules/unicorn.js

roryabraham · 2025-10-20T22:14:42Z

@NJ-2020 you need to sign the CLA for this repo before I can merge this.

NJ-2020 · 2025-10-21T07:17:46Z

@roryabraham FYI, I just added new eslint rules for some another tasks. Thanks

NJ-2020 · 2025-10-21T07:18:53Z

@NJ-2020 you need to sign the CLA for this repo before I can merge this.

@roryabraham I've already signed the CLA for this repo, but I am still seeing the workflow is failing, is there anything I am missing something?

roryabraham · 2025-10-21T22:17:59Z

@NJ-2020 you've got conflicts to fix here. CLA bot is broken by something else. I'll look into it ASAP

roryabraham · 2025-10-22T05:46:35Z

I have identified the problem with the CLA. It should be fixed tomorrow

roryabraham · 2025-10-22T06:45:38Z

Putting this on HOLD temporarily because publishing is broken in this repo. Hopefully should be fixed tomorrow

roryabraham · 2025-10-22T22:16:08Z

CLA is fixed! still working on fixing npm publishing in this repo

roryabraham · 2025-10-23T00:54:09Z

npm publish is fixed. Taking this off hold

NJ-2020 · 2025-10-23T00:54:13Z

@NJ-2020 you've got conflicts to fix here. CLA bot is broken by something else. I'll look into it ASAP

Fixed ☑️ Thanks

rules/unicorn.js


    languageOptions: {
        parserOptions: {
            globals: globals.builtin,


gelocraft · 2025-10-23T01:18:35Z

@NJ-2020 I think you're having some trouble with merge conficts? Let me help you.

I think the first thing you have to do is to sync your main fork
After syncing your fork, in your local copy run git fetch origin
After fetching origin, make sure u stash your changes from your current branch
Run git stash -u to stash all the modified and untracked files
Reset your commit head to origin/main

git reset --hard origin/main

Finally, you're now ready adding new changes
After you commit your changes, forced push your commits to your pr branch

gelocraft · 2025-10-23T01:20:22Z

@NJ-2020 I think you're having some trouble with merge conficts? Let me help you.

I think the first thing you have to do is to sync your main fork

After syncing your fork, in your local copy run git fetch origin

After fetching origin, make sure u stash your changes from your current branch

Run git stash -u to stash all the modified and untracked files

Reset your commit head to origin/main
git reset --hard origin/main
Finally, you're now ready adding new changes

After you commit your changes, forced push your commits to your pr branch

And by doing all of these, it will make the commit history clean. Cool, right?

NJ-2020 · 2025-10-23T01:21:51Z

#163 (comment), #163 (comment)

@gelocraft Thank you, FYI I am having some issues with my prettier vscode/codebase

gelocraft · 2025-10-23T01:24:10Z

@NJ-2020 I think it would be better to add the lint rules one at a time in separate PRs. Doing them all in a single PR could go against the code of conduct (GET SHIT DONE) and contributing guidelines.

gelocraft · 2025-10-23T01:51:28Z

#163 (comment), #163 (comment)

@gelocraft Thank you, FYI I am having some issues with my prettier vscode/codebase

hmm... not sure about that. i use neovim btw

NJ-2020 · 2025-10-23T02:10:42Z

@roryabraham I think we're good to merge. Tests & lint for the changed files check are passing (tested locally).

gelocraft · 2025-10-23T02:12:04Z

Explanation of Change

Add new plugin (eslint-plugin-unicorn) & some new rules:

Enforce that .find or .findLast are being used instead of .filter

Enforce to use .replaceAll instead of .replace when dealing over regex searches

Enforce to use set.size instead of Array.from(set).length for better performance

$: Expensify/App#67423 Expensify/App#67424 Expensify/App#67425

PROPOSAL: Expensify/App#67423 (comment) Expensify/App#67424 (comment) Expensify/App#67425 (comment)

@roryabraham wouldn’t submitting fixes for all assigned issues in a single PR go against the project’s contributing guidelines and code of conduct? Each issue should ideally have its own PR, right?

NJ-2020 · 2025-10-23T02:21:47Z

@roryabraham wouldn’t submitting fixes for all assigned issues in a single PR go against the project’s contributing guidelines and code of conduct? Each issue should ideally have its own PR, right?

@gelocraft FYI, usually I always do separate PR for each issue (E/App, expensify-common), but at this point (eslint-config-expensify), I don't think it's really necessary to create separate PR for each new rule (small changes) and the current PR doesn't need too much review and since this is straightforward PR and hasn't been merged yet, so I don't see any issues including other rule.

If this is still against (eslint-config-expensify) the project’s contributing guidelines and code of conduct, I will make sure to create separate PR for each lint/rule/issue

Thanks.

roryabraham · 2025-10-23T16:59:29Z

wouldn’t submitting fixes for all assigned issues in a single PR go against the project’s contributing guidelines and code of conduct? Each issue should ideally have its own PR, right?

I certainly don't think it's a code of conduct violation. It may be somewhere in the contributing guidelines that smaller PRs are better, because that's certainly one of our best practices. But in some cases, the same change might naturally fix multiple bugs, and that's ok.

In this case, I agree with @gelocraft that it would be better to add each rule in a separate pull request. That way we get more granular releases, allowing for separate E/App PRs to enable each rule individually. That is in everyone's best interest for several reasons:

It makes it easier to track which PR is associated with which issue for payment sake
It reduces the likelihood of any individual PR causing a regression, and if one rule change
ends up having to be reverted, they don't all have to be reverted.
Smaller PRs generally means fewer conflicts, which often results in greater velocity of code actually being merged and deployed.
Multiple C+ reviewers can be assigned to review each PR, and each PR has a smaller testing surface

roryabraham

Let's enable all the rules in separate PRs

NJ-2020 · 2025-10-25T03:55:02Z

@roryabraham Done, updated ☑️

NJ-2020 · 2025-10-25T04:07:33Z

Draft PRs is here (HOLD):

NJ-2020 · 2025-10-27T03:19:37Z

@roryabraham I think we're good to merge 😁, please let me know if you need anything from my side. Thanks

os-botify · 2025-10-28T21:25:39Z

🚀 Published to npm in 2.0.95 🎉

add new plugin/rule eslint-plugin-unicorn

d5524ab

melvin-bot bot assigned NJ-2020 Oct 19, 2025

This comment was marked as resolved.

Sign in to view

NJ-2020 mentioned this pull request Oct 19, 2025

[Due for payment 2025-11-20] [$250] Enable prefer-array-find eslint rule Expensify/App#67423

Closed

roryabraham reviewed Oct 20, 2025

View reviewed changes

rules/unicorn.js Show resolved Hide resolved

roryabraham previously approved these changes Oct 20, 2025

View reviewed changes

add more rules

77c0236

NJ-2020 dismissed roryabraham’s stale review via 77c0236 October 21, 2025 06:44

This was referenced Oct 21, 2025

[Due for payment 2025-11-26] [$250] Enable prefer-string-replace-all ESLint rule Expensify/App#67425

Closed

[Due for payment 2025-11-21] [$250] Enable prefer-set-size ESLint rule Expensify/App#67424

Closed

gelocraft mentioned this pull request Oct 21, 2025

feature: enable unicorn/prefer-set-has rule #164

Merged

roryabraham changed the title ~~Add new plugin/rule for eslint-plugin-unicorn~~ [HOLD] Add new plugin/rule for eslint-plugin-unicorn Oct 22, 2025

CLABotify added a commit to Expensify/CLA that referenced this pull request Oct 22, 2025

@NJ-2020 has signed the CLA in Expensify/eslint-config-expensify#163

ec26829

fix conflicts

5eb1b12

roryabraham changed the title ~~[HOLD] Add new plugin/rule for eslint-plugin-unicorn~~ Add new plugin/rule for eslint-plugin-unicorn Oct 23, 2025

NJ-2020 commented Oct 23, 2025

View reviewed changes

rules/unicorn.js

languageOptions: {

parserOptions: {

globals: globals.builtin,

This comment was marked as resolved.

Sign in to view

NJ-2020 added 2 commits October 23, 2025 08:03

fix lint error

30a35a7

fix linter errors

f279c82

revert uncessary changes

aa0c868

fix: enforce to use .replaceAll instead .replace

e7c06e0

NJ-2020 mentioned this pull request Oct 23, 2025

fix: enforce to use .replaceAll instead of .replace Expensify/App#73286

Closed

54 tasks

roryabraham requested changes Oct 23, 2025

View reviewed changes

NJ-2020 added 2 commits October 25, 2025 10:52

remove some rules

858fc1d

remove uncessary changes

83cc85e

NJ-2020 changed the title ~~Add new plugin/rule for eslint-plugin-unicorn~~ Enable prefer-array-find unicorn eslint rule Oct 25, 2025

NJ-2020 requested a review from roryabraham October 25, 2025 03:55

roryabraham approved these changes Oct 28, 2025

View reviewed changes

roryabraham merged commit 7debd2f into Expensify:main Oct 28, 2025
6 checks passed

Enable prefer-array-find unicorn eslint rule #163

Enable prefer-array-find unicorn eslint rule #163

Uh oh!

Conversation

NJ-2020 commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Uh oh!

github-actions bot commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NJ-2020 commented Oct 19, 2025

Uh oh!

NJ-2020 commented Oct 19, 2025

Uh oh!

This comment was marked as resolved.

Uh oh!

roryabraham commented Oct 20, 2025

Uh oh!

NJ-2020 commented Oct 21, 2025

Uh oh!

NJ-2020 commented Oct 21, 2025

Uh oh!

roryabraham commented Oct 21, 2025

Uh oh!

roryabraham commented Oct 22, 2025

Uh oh!

roryabraham commented Oct 22, 2025

Uh oh!

roryabraham commented Oct 22, 2025

Uh oh!

roryabraham commented Oct 23, 2025

Uh oh!

NJ-2020 commented Oct 23, 2025

Uh oh!

This comment was marked as resolved.

Uh oh!

gelocraft commented Oct 23, 2025

Uh oh!

gelocraft commented Oct 23, 2025

Uh oh!

NJ-2020 commented Oct 23, 2025

Uh oh!

gelocraft commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gelocraft commented Oct 23, 2025

Uh oh!

NJ-2020 commented Oct 23, 2025

Uh oh!

gelocraft commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Uh oh!

NJ-2020 commented Oct 23, 2025

Uh oh!

roryabraham commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

NJ-2020 commented Oct 25, 2025

Uh oh!

NJ-2020 commented Oct 25, 2025

Uh oh!

NJ-2020 commented Oct 27, 2025

Uh oh!

Uh oh!

os-botify bot commented Oct 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NJ-2020 commented Oct 19, 2025 •

edited

Loading

github-actions bot commented Oct 19, 2025 •

edited

Loading

gelocraft commented Oct 23, 2025 •

edited

Loading

gelocraft commented Oct 23, 2025 •

edited

Loading

roryabraham commented Oct 23, 2025 •

edited

Loading