Open
Conversation
MiroDojkic
reviewed
Mar 18, 2026
| h: number; | ||
| }; | ||
| } | ||
| export type PanelPosition = { |
Member
There was a problem hiding this comment.
Why break this type out of the Panel namespace?
droguljic
requested changes
Mar 19, 2026
| // - panels (long-window SLI, long-window error budget) | ||
| // - alerts (long-window burn, short-window burn) | ||
| export namespace GrafanaDashboard { | ||
| export type DataSources = { |
Contributor
There was a problem hiding this comment.
I would opt for singular since this is not an array type.
| prometheus?: pulumi.Output<string>; | ||
| }; | ||
|
|
||
| export interface DashboardConfig { |
Contributor
There was a problem hiding this comment.
Why not just Config or Configuration?
| title: pulumi.Output<string>; | ||
| panels: Grafana.Panel[] = []; | ||
| tags?: pulumi.Output<string[]>; | ||
| private panelBuilders: (( |
Contributor
There was a problem hiding this comment.
This inline type is not that readable; extract it into a dedicated type variable.
src/components/grafana/grafana.ts
Outdated
| name: string; | ||
| grafanaIamRole: aws.iam.Role; | ||
| prometheusDataSource?: grafana.oss.DataSource; | ||
| dashboards: grafana.oss.Dashboard[] = []; |
Contributor
There was a problem hiding this comment.
Why initialize it as an empty array and not mark it as optional?
mandryllo
reviewed
Mar 27, 2026
Comment on lines
+32
to
+33
| timezone: 'browser', | ||
| refresh: '10s', |
Collaborator
There was a problem hiding this comment.
I feel these should be configurable with these values as defaults
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes dashboard configuration more flexible. It enables passing different dashboards to the Grafana builder component, adds support for custom dashboard builders, and allows adding custom panels to the existing web server SLO dashboard builder.