Extend custom mode API with start/end and keyword mapping #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@F0rce I realised too late that the JS changes should have been done in https://github.com/f0rce/lit-ace instead of in this project. If you're OK with the proposed changes I'll split up this PR into one for lit-ace and one for this project. |
|
@pepijnve jeah, I should have mentioned anywhere, that JS changes have to be made in https://github.com/F0rce/lit-ace The feature sound really interesting and I'll be sure to check it out as soon as the development is done. If you need help with the JS part, just ping me in the PR and I'll be sure to help you out. LGTM |
|
F0rce/lit-ace#11 here you go. I can update this PR once there's a build containing that enhancement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two extra capabilities to the custom mode rule Java API:
With these two changes modes like the SQL mode can be completely defined via the Java API.