pimd : Added support for multi-oif static mroute #19765
Merged
+107
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-wing
force-pushed
the
bugfix/ip_static_mroute
branch
from
fc59435 to
f24459e
Compare
|
could we get a topotest that shows that this works properly now? |
|
Ofc I'm working on it :) |
e-wing
force-pushed
the
bugfix/ip_static_mroute
branch
from
f0c04fb to
b4ceac2
Compare
|
Squashed the 3 commits for simplicity |
ton31337
reviewed
Oct 17, 2025
e-wing
force-pushed
the
bugfix/ip_static_mroute
branch
2 times, most recently
from
e988087 to
8fcf197
Compare
nabahr
requested changes
Oct 21, 2025
|
Some simple style issues found. |
e-wing
force-pushed
the
bugfix/ip_static_mroute
branch
from
8fcf197 to
db7d96b
Compare
Signed-off-by: e-wing <[email protected]>
e-wing
force-pushed
the
bugfix/ip_static_mroute
branch
from
db7d96b to
e5fda7b
Compare
|
Applied the styling and removed dead code 👍 |
nabahr
approved these changes
Oct 21, 2025
Jafaral
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug with ip mroute handling : the internal data model did not handle multiple oifs for a same {iif, src, grp}.
This caused unpredictable behavior when adding and deleting such routes (zombie resident mroutes for example).