increasing vtysh cli length constraint #20110
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raja-rajasekar
force-pushed
the
rajasekarr/cli_limit
branch
2 times, most recently
from
a574f97 to
7977800
Compare
ton31337
reviewed
Nov 22, 2025
|
|
||
| step("Configuring route-map with 150 large communities (~4770 bytes)") | ||
| router = tgen.gears["r1"] | ||
| cmd = "configure terminal\n" |
Member
There was a problem hiding this comment.
Please use f-string, e.g.:
output = router.vtysh_cmd(
"""
configure terminal
route-map LARGE_COMM_150 permit 10
set large-community {large_comm_str}
""")
raja-rajasekar
force-pushed
the
rajasekarr/cli_limit
branch
from
7977800 to
45c6a7f
Compare
mjstapp
reviewed
Nov 24, 2025
lib/vty.c
Outdated
| /* Clear command line buffer. */ | ||
| vty->cp = vty->length = 0; | ||
| vty_clear_buf(vty); | ||
| flog_err(EC_LIB_VTY, "Command too long: %.*s", nbytes, buf); |
Contributor
There was a problem hiding this comment.
hmm - is it necessary to spam the log with the entire buffer? if you think adding an error would be useful, maybe just emit the start of the command?
Contributor
Author
There was a problem hiding this comment.
Done.
now we would see 80chars and something like
2025/11/24 18:36:45 BGP: [VNXE7-TGXN3][EC 100663304] Command too long (512 bytes): 4967295:4294967031 4294967295:4294967295:4294967032 4294967295:4294967295:429496...
Signed-off-by: Manpreet Kaur <[email protected]>
raja-rajasekar
force-pushed
the
rajasekarr/cli_limit
branch
from
45c6a7f to
3cad9a6
Compare
Adding flog_err to log the error when the cli entered by user exceeds 8k limit We would see something like 2025/11/24 18:36:45 BGP: [VNXE7-TGXN3][EC 100663304] Command too long (XYZ bytes): 4967295:4294967031 4294967295:4294967295:4294967032 4294967295:4294967295:429496... Signed-off-by: Manpreet Kaur <[email protected]> Signed-off-by: Rajasekar Raja <[email protected]>
Test that 150 large communities with max-sized values can be configured in a route-map, exceeding the old 4096 byte limit and requiring the 8192 byte buffer increase. Signed-off-by: Rajasekar Raja <[email protected]>
raja-rajasekar
force-pushed
the
rajasekarr/cli_limit
branch
from
3cad9a6 to
5d3e23f
Compare
Contributor
Author
|
ci:rerun |
mjstapp
approved these changes
Nov 24, 2025
Contributor
Author
|
ci:rerun |
1 similar comment
Contributor
Author
|
ci:rerun |
ton31337
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increasing vtysh cli length constraint
If we have 150 large communities using maximum-sized values, we exceed 4096 bytes (4,770 bytes).. Fixing this
4294967295:4294967295:4294967150
% Command is too long.
% [BGP] Unknown command: 67295:4294967124 4294967295:4294967295:4294967125 4294967295:4294967295:4294967126 4294967295:4294967295:4294967127 4294967295:4294967295:4294967128 4294967295:4294967295:4294967129 4294967295:4294967295:4294967130 4294967295:4294967295:4294967131 4294967295:4294967295:4294967132 4294967295:4294967295:4294967133 4294967295:4294967295:429496