Skip to content

Fixed compilation errors and problems with Packages and Packagers #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: mc1.20.1/fabric/dev
Choose a base branch
from

Conversation

SpacePython12
Copy link

There's a couple of classes here that were causing compilation errors because they were expecting Forge classes and interfaces, so I just put some placeholder code there so that it actually compiles.

Also, Package entities weren't being synced with the server correctly because of a missing super call (and it took me three days to figure that one out lol).

Finally, the Packager properly uses Fabric's transfer API now and doesn't void packages (or crash the game).

@SpacePython12 SpacePython12 changed the title It's like, actually functional now, yay Fixed compilation errors and problems with Packages and Packagers Jul 8, 2025
@Eggmanplant
Copy link

Eggmanplant commented Jul 8, 2025

Thanks! Check some bugs in #1772.

EDIT: Please change the version number to accommodate 6.0.6.

@SpacePython12
Copy link
Author

Thanks! Check some bugs in #1772.

EDIT: Please change the version number to accommodate 6.0.6.

Oh yeah, I saw that lol. I’ll fix it when I get the chance. I’ll also bump the version too

@SpacePython12
Copy link
Author

The rendering issues are gonna be harder to fix, it looks like an issue with Flywheel and Flywheel's documentation sucks

@Eggmanplant
Copy link

Eggmanplant commented Jul 8, 2025

The rendering issues are gonna be harder to fix, it looks like an issue with Flywheel and Flywheel's documentation sucks

EDIT: On your thing, the mixer works fine. Boxes work fine, too.

@J-eremy
Copy link

J-eremy commented Jul 8, 2025

Can confirm, Built against Java 17 and the build was successful and runs in game. Nice work @SpacePython12
image

Copy link
Member

@TropheusJ TropheusJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate it, but there's a few problems.

Please don't bump the version number. That would be incorrect without a full merge from Forge.

The rendering issues are known with a planned fix.

@SpacePython12
Copy link
Author

SpacePython12 commented Jul 13, 2025

Alright, I acknowledged your suggestions, @TropheusJ. Sorry, I'm new to the whole contributing to open source thing.

@Eggmanplant
Copy link

Eggmanplant commented Jul 13, 2025

I appreciate it, but there's a few problems.

Please don't bump the version number. That would be incorrect without a full merge from Forge.

The rendering issues are known with a planned fix.

Thanks! For some reason, IThundxr wouldn't tell me that about the graphics issues. I requested to bump the version cuz there is one commit that states: Merge v6.0.6.

EDIT: Oh, it fails to build again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants