Add failing regression test for #6032 - #6150
Open
Dongnyoung wants to merge 2 commits into
Open
Conversation
Code Review ✅ ApprovedAdds a failing regression test covering serialization ordering when sorting creator properties and properties alphabetically are both enabled. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a failing test for #6032.
The new test covers serialization ordering when both:
MapperFeature.SORT_CREATOR_PROPERTIES_FIRSTMapperFeature.SORT_PROPERTIES_ALPHABETICALLYare enabled.
It verifies the existing behavior for a constructor annotated with
@ConstructorProperties, where the constructor property is sorted first.It also adds a
@JacksonTestFailureExpectedcase showing that an unannotatedsingle-argument constructor is currently treated as a creator property for
serialization ordering, causing
bbto be written beforeaa.No production code changes are included.
Tested with: