Conversation
e-nomem
force-pushed
the
add-ed25519-keys
branch
from
December 5, 2024 03:48
ece3a2a to
d17275a
Compare
|
I tried this out using Debian 13 with a YubiKey 5.7.1. The setup configured an ed25519 key, which was exposed in the agent afterwards. Finally connecting to a server key worked without issues. Using an older YubiKey 5.2.7 resulted in an ecdsa key instead, as expected. All good! 😀 |
|
is this likely to be merged at some point? |
e-nomem
force-pushed
the
add-ed25519-keys
branch
from
October 26, 2025 05:59
d17275a to
0c24623
Compare
e-nomem
force-pushed
the
add-ed25519-keys
branch
from
October 26, 2025 06:01
0c24623 to
59bf94f
Compare
quite
approved these changes
Oct 26, 2025
quite
left a comment
quite
left a comment
There was a problem hiding this comment.
This looks pretty good. I have used go-piv for ed25519 on Yubikey in another project, and it was solid.
I'm not entirely convinced of switching to AES256 in the same commit.
Also, myself I have been doing semver comparisons using golang.org/x/mod/semver, which felt like a sensible dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically the same as #26 but implements the automatic algo selection by checking the firmware version as you mentioned in the other PR.
Yubikeys officially added support for Ed25519 keys in firmware version 5.7.0. Upstream piv-go added support for it in go-piv/piv-go#157 (released in
v2.2.0).Note that Yubikey firmware 5.4.0 (technically 5.4.2 but I used the same version check as piv-go, see this comment) added support for AES management keys so I also used the same firmware version detection method to upgrade the management key to AES256.
Tested locally on macOS Sequoia with Yubikey firmware 5.7.1