Skip to content

Conversation

@jjw24
Copy link
Member

@jjw24 jjw24 commented Jul 30, 2021

Allows users to trigger and search Quick Access on its own

Tested:

  • Changing to global action keyword '*' will show prompt to disallow
  • Disabling Quick Access action keyword will return it to global action keyword '*'
  • Using Quick Access action keyword can list and search only within the list of saved files/folders
  • Using Path Search action keyword can list, search within the list of saved files/folders and as well as its original behaviour of searching paths
  • Using other action keywords can not list Quick Access
  • Upgrading from Explorer version <1.8.0 to 1.9.0
  • Upgrading from Explorer version >1.8.0 to 1.9.0

@jjw24 jjw24 added enhancement New feature or request Explorer Plugin Issue or Enhancement Link to Explorer Plugin labels Jul 30, 2021
@jjw24 jjw24 added this to the 1.9.0 milestone Jul 30, 2021
@jjw24 jjw24 self-assigned this Jul 30, 2021
@taooceros
Copy link
Member

I have found a bug for explorer plugin....We have added plenty of global action keyword (in 1.8.1, haven't tried this build).
Probably whenever we disable & enable a setting, a new global wildcard will be added.
image

@jjw24
Copy link
Member Author

jjw24 commented Aug 1, 2021

Let's fix this in a seperate PR so we can roll it out as 1.8.3 instead of this feature PR. Are you already looking into this issue? If not i can. Let me know so we dont double up.

@jjw24
Copy link
Member Author

jjw24 commented Aug 1, 2021

i have tried enabling/disabling, changing action keyword and then disabling, i cant replicate. Can you let me know the steps how to repro please.

@taooceros
Copy link
Member

Sorry I has been a bit busy these few days. I don't know how to replicate this, because I just observe the situation. I will take a check later.
By the way, probably the better to handle actionkeyword here is not assign a global wildcard to every specific option, but just maintain a global wildcard actionkeyword that won't be removed.

Let me check our logic in change duplicate global wildcard actionkeyword.

@taooceros
Copy link
Member

I found the way to replicate. Everytime restarting flow, two more "*" will be added to actionkeywords.

@taooceros
Copy link
Member

Oh it is because the fix for backward compability

@jjw24
Copy link
Member Author

jjw24 commented Aug 5, 2021

Sorry I has been a bit busy these few days. I don't know how to replicate this, because I just observe the situation. I will take a check later.

All good, no stress :)

@jjw24 jjw24 requested review from taooceros and removed request for taooceros August 6, 2021 08:07
@jjw24 jjw24 requested a review from taooceros August 6, 2021 08:52
taooceros
taooceros previously approved these changes Aug 6, 2021
@jjw24
Copy link
Member Author

jjw24 commented Sep 15, 2021

@taooceros I have done a merge of dev branch, no changes added, could you re-approve please

@jjw24 jjw24 merged commit 661b8cf into dev Sep 23, 2021
@jjw24 jjw24 deleted the add_quickaccess_actionkeyword branch September 23, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Explorer Plugin Issue or Enhancement Link to Explorer Plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants