Add JsonRPCPlugin.cs Rerun implementation #648

taooceros · 2021-08-12T04:33:44Z

#635

pc223 · 2021-08-13T05:47:49Z

So excited to try this out! Is it ready for test? The build is failed 😄

taooceros · 2021-08-13T06:02:27Z

Yeah you can test it out. It is not a complex change so I believe my logic (haven't tested it out myself XD).

taooceros · 2021-08-13T06:07:35Z

I would like to implement this after #653, but currently it should work fine.

pc223 · 2021-08-13T06:50:50Z

Tested the RerunDelay seems work OK 👍

@Garulf yo check this out! Is this what you request? 😄

Plugin code, generate random number, rerun every 200ms

import json
import sys


def main():
    request_data = sys.argv[1]
    request_dictionary = json.loads(request_data)
    if request_dictionary['method'] == 'query':
        import random
        response_dictionary = {
            'result': [
                {
                    "Title": f"{random.random()}",
                    "SubTitle": "This is my hello world",
                    "IconPath": "favicon.ico",
                    "JsonRPCAction": {
                        'method': 'Flow.Launcher.ShowApp',
                        'parameters': [],
                    },
                    
                },
            ],
            "RerunDelay":200,
        }


        response_converted_to_json_string = json.dumps(response_dictionary)
        print(response_converted_to_json_string)
    

if __name__ == '__main__':
    main()

Garulf · 2021-08-13T06:53:06Z

Tested the RerunDelay seems work OK 👍

@Garulf yo check this out! Is this what you request? 😄

Plugin code, generate random number, rerun every 200ms

import json
import sys


def main():
    request_data = sys.argv[1]
    request_dictionary = json.loads(request_data)
    if request_dictionary['method'] == 'query':
        import random
        response_dictionary = {
            'result': [
                {
                    "Title": f"{random.random()}",
                    "SubTitle": "This is my hello world",
                    "IconPath": "favicon.ico",
                    "JsonRPCAction": {
                        'method': 'Flow.Launcher.ShowApp',
                        'parameters': [],
                    },
                    
                },
            ],
            "RerunDelay":200,
        }


        response_converted_to_json_string = json.dumps(response_dictionary)
        print(response_converted_to_json_string)
    

if __name__ == '__main__':
    main()

its... its beautiful!!! @taooceros you're awesome!

Going to try this out as soon as I can!

Garulf · 2021-08-13T07:03:32Z

Any chance to have the loading bar trigger while a rerun is scheduled? For example when polling a external web API you dont want to hit it too often. But it may be beneficial to indicate that Flow is still working.

Edit:
Mouse is flashing between a loading indicator and normal cursor after using this method. Almost like the scheduled rerun hasnt been canceled.

Edit2: Yeah, log shows scheduled reruns are not halting after Flow's window closes. Flow is closed yet its still rerunning in the background.

Edit3: selection jumping to top on each rerun if you use arrow keys to select you're selection will keep jumping to the top of the list.

Garulf · 2021-08-13T07:20:10Z

Previously you couldn't see if your action went through, but now its immediately obvious if the toggle fails or not:

Very cool!

taooceros · 2021-08-13T07:26:20Z

Yeah we do, let me change a bit.

pc223 · 2021-08-13T07:36:00Z

@taooceros Quick consult, do you see this code have any obvious problem? This breaks after a merge this PR to my personal code (have customized debug logs). It breaks if I typing fast on a Python plugins. I'll make a detail bug report later if needed.

JsonRPCPlugin.cs:246

// Mutate intercept source

// Upstream `source`
// await using var source = process.StandardOutput.BaseStream;

await using var mySource = process.StandardOutput.BaseStream; 

var debugOuput = mySource.ReadToEnd();
Log.Debug($"|JsonRPCPlugin.ExecuteAsync|result:<{debugOuput}>");
var bytesOutput = Encoding.UTF8.GetBytes(debugOuput);

await using var source = new MemoryStream(bytesOutput);

taooceros · 2021-08-13T07:45:36Z

@taooceros Quick consult, do you see this code have any obvious problem? This breaks after a merge this PR to my personal code (have customized debug logs). It breaks if I typing fast on a Python plugins. I'll make a detail bug report later if needed.

JsonRPCPlugin.cs:246
// Mutate intercept source

// Upstream `source`
// await using var source = process.StandardOutput.BaseStream;

await using var mySource = process.StandardOutput.BaseStream; 

var debugOuput = mySource.ReadToEnd();
Log.Debug($"|JsonRPCPlugin.ExecuteAsync|result:<{debugOuput}>");
var bytesOutput = Encoding.UTF8.GetBytes(debugOuput);

await using var source = new MemoryStream(bytesOutput);

Could you upload it as a branch in your fork, so I can see more code which leads to the problem.

taooceros · 2021-08-13T07:53:25Z

@taooceros Quick consult, do you see this code have any obvious problem? This breaks after a merge this PR to my personal code (have customized debug logs). It breaks if I typing fast on a Python plugins. I'll make a detail bug report later if needed.

JsonRPCPlugin.cs:246
// Mutate intercept source

// Upstream `source`
// await using var source = process.StandardOutput.BaseStream;

await using var mySource = process.StandardOutput.BaseStream; 

var debugOuput = mySource.ReadToEnd();
Log.Debug($"|JsonRPCPlugin.ExecuteAsync|result:<{debugOuput}>");
var bytesOutput = Encoding.UTF8.GetBytes(debugOuput);

await using var source = new MemoryStream(bytesOutput);

Oh probably if you type faster, the request will be canceled? So only the last one may be log.

pc223 · 2021-08-13T08:13:35Z

@taooceros Here is the code that breaks, it just for log out the RPC response of python plugin

pc223@1cef772

These lines are the only different compare to this PR

// await using var source = process.StandardOutput.BaseStream;
await using var mySource = process.StandardOutput.BaseStream; 

var debugOuput = mySource.ReadToEnd();
Log.Debug($"|JsonRPCPlugin.ExecuteAsync|result:<{debugOuput}>");


var bytesOutput = Encoding.UTF8.GetBytes(debugOuput);

await using var source = new MemoryStream(bytesOutput);

taooceros · 2021-08-13T08:42:22Z

Have you merged upstream/dev? You may need to fetch first. Or simply git pull upstream(or the remote pointing main repo) dev. There should be conflict between it.

pc223 · 2021-08-13T08:44:40Z

Have you merged upstream/dev? You may need to fetch first. Or simply git pull upstream(or the remote pointing main repo) dev. There should be conflict between it.

Check out https://github.com/pc223/Flow.Launcher/tree/JsonRPCRerun on my repo, I modified directly base on this PR

Garulf · 2021-08-13T09:18:52Z

Getting errors with latest build: df62935

Please open new issue in: https://github.com/Flow-Launcher/Flow.Launcher/issues/new
1. upload log file: E:\Users\Garulf\Apps\FlowLauncher\app-1.8.2\UserData\Logs\1.8.2\2021-08-13.txt
2. copy below exception message

Flow Launcher version: 1.8.2
OS Version: Microsoft Windows NT 10.0.19043.0
IntPtr Length: 8
x64: True

Python Path: E:\Users\Garulf\Apps\FlowLauncher\app-1.8.2\UserData\PythonEmbeddable\pythonw.exe
Date: 08/13/2021 05:17:07
Exception:
System.IO.InvalidDataException: HA-Commander|Traceback (most recent call last):
  File "E:\Users\Garulf\Apps\FlowLauncher\app-1.8.2\UserData\Plugins\HA-Commander\main.py", line 13, in <module>
    Commander()
  File "E:\Users\Garulf\Apps\FlowLauncher\app-1.8.2\UserData\Plugins\HA-Commander\plugin\main.py", line 34, in __init__
    super().__init__()
  File "E:\Users\Garulf\Apps\FlowLauncher\app-1.8.2\UserData\Plugins\HA-Commander\lib\flox\flox.py", line 84, in __init__
    super().__init__()
  File "E:\Users\Garulf\Apps\FlowLauncher\app-1.8.2\UserData\Plugins\HA-Commander\lib\flox\launcher.py", line 26, in __init__
    request_method = dict(methods)[request_method_name]
KeyError: 'query_rerun'

   at Flow.Launcher.Core.Plugin.JsonRPCPlugin.ExecuteAsync(ProcessStartInfo startInfo, CancellationToken token) in C:\projects\flow-launcher\Flow.Launcher.Core\Plugin\JsonRPCPlugin.cs:line 254
   at Flow.Launcher.Core.Plugin.JsonRPCPlugin.ExecuteAsync(ProcessStartInfo startInfo, CancellationToken token) in C:\projects\flow-launcher\Flow.Launcher.Core\Plugin\JsonRPCPlugin.cs:line 268
   at Flow.Launcher.Core.Plugin.JsonRPCPlugin.<>c__DisplayClass18_0.<<QueryAsync>g__TryRerun|0>d.MoveNext() in C:\projects\flow-launcher\Flow.Launcher.Core\Plugin\JsonRPCPlugin.cs:line 297
--- End of stack trace from previous location ---
   at Flow.Launcher.Core.Plugin.JsonRPCPlugin.QueryAsync(Query query, CancellationToken token) in C:\projects\flow-launcher\Flow.Launcher.Core\Plugin\JsonRPCPlugin.cs:line 281
   at Flow.Launcher.Core.Plugin.JsonRPCPlugin.QueryAsync(Query query, CancellationToken token) in C:\projects\flow-launcher\Flow.Launcher.Core\Plugin\JsonRPCPlugin.cs:line 282
   at Flow.Launcher.Core.Plugin.PluginManager.<>c__DisplayClass22_0.<<QueryForPluginAsync>b__0>d.MoveNext() in C:\projects\flow-launcher\Flow.Launcher.Core\Plugin\PluginManager.cs:line 192
--- End of stack trace from previous location ---
   at Flow.Launcher.Infrastructure.Stopwatch.DebugAsync(String message, Func`1 action) in C:\projects\flow-launcher\Flow.Launcher.Infrastructure\Stopwatch.cs:line 34
   at Flow.Launcher.Core.Plugin.PluginManager.QueryForPluginAsync(PluginPair pair, Query query, CancellationToken token) in C:\projects\flow-launcher\Flow.Launcher.Core\Plugin\PluginManager.cs:line 191
   at Flow.Launcher.ViewModel.MainViewModel.<>c__DisplayClass111_0.<<QueryResults>g__QueryTask|2>d.MoveNext() in C:\projects\flow-launcher\Flow.Launcher\ViewModel\MainViewModel.cs:line 553
--- End of stack trace from previous location ---
   at Flow.Launcher.ViewModel.MainViewModel.QueryResults() in C:\projects\flow-launcher\Flow.Launcher\ViewModel\MainViewModel.cs:line 527
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__140_0(Object state)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

taooceros · 2021-08-13T09:20:38Z

Yeah I change the method of query rerun to "query_rerun" to indicate it is a rerun.
Forget to do that in last build.

Garulf · 2021-08-13T09:24:28Z

Yeah I change the method of query rerun to "query_rerun" to indicate it is a rerun.
Forget to do that in last build.

Ah! I see.

pc223 · 2021-08-13T11:17:53Z

Seems Esc or change focus does not stop the rerun, maybe the token is not canceled?

taooceros · 2021-08-13T11:19:23Z

Yeah that's true.

taooceros · 2021-08-13T22:43:41Z

Have you merged upstream/dev? You may need to fetch first. Or simply git pull upstream(or the remote pointing main repo) dev. There should be conflict between it.

Check out https://github.com/pc223/Flow.Launcher/tree/JsonRPCRerun on my repo, I modified directly base on this PR

Probably it doesn't work because you didn't seek to origin, so the getbytes is creating nothing. You can do it like this.

                try
                {
                    // token expire won't instantly trigger the exception, 
                    // manually kill process at before
                    await source.CopyToAsync(buffer, token);
                }
                catch (OperationCanceledException)
                {
                    await buffer.DisposeAsync();
                    return Stream.Null;
                }
+              buffer.Seek(0, SeekOrigin.Begin);
+              var debugOuput = await new StreamReader(buffer).ReadToEndAsync();
+
+              Log.Debug($"|JsonRPCPlugin.ExecuteAsync|result:<{debugOuput}>");

taooceros · 2021-08-13T22:46:22Z

It is also possible that the process is killed so the stream won't read anything

Add JsonRPCPlugin.cs Rerun implementation

49d88b6

taooceros marked this pull request as draft August 12, 2021 04:35

Change rerun method signature

9b17c75

Fix test

4500956

Keep loading bar until the plugin stop rerun

df62935

github-actions bot added the no-pr-activity label Jul 31, 2022

taooceros closed this Jun 19, 2024

jjw24 deleted the JsonRPCRerun branch June 22, 2024 03:07

Uh oh!

Add JsonRPCPlugin.cs Rerun implementation #648

Add JsonRPCPlugin.cs Rerun implementation #648

Uh oh!

Conversation

taooceros commented Aug 12, 2021

Uh oh!

pc223 commented Aug 13, 2021

Uh oh!

taooceros commented Aug 13, 2021

Uh oh!

taooceros commented Aug 13, 2021

Uh oh!

pc223 commented Aug 13, 2021

Uh oh!

Garulf commented Aug 13, 2021

Uh oh!

Garulf commented Aug 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Garulf commented Aug 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taooceros commented Aug 13, 2021

Uh oh!

pc223 commented Aug 13, 2021

Uh oh!

taooceros commented Aug 13, 2021

Uh oh!

taooceros commented Aug 13, 2021

Uh oh!

pc223 commented Aug 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taooceros commented Aug 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pc223 commented Aug 13, 2021

Uh oh!

Garulf commented Aug 13, 2021

Uh oh!

taooceros commented Aug 13, 2021

Uh oh!

Garulf commented Aug 13, 2021

Uh oh!

pc223 commented Aug 13, 2021

Uh oh!

taooceros commented Aug 13, 2021

Uh oh!

taooceros commented Aug 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taooceros commented Aug 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Garulf commented Aug 13, 2021 •

edited

Loading

Garulf commented Aug 13, 2021 •

edited

Loading

pc223 commented Aug 13, 2021 •

edited

Loading

taooceros commented Aug 13, 2021 •

edited

Loading

taooceros commented Aug 13, 2021 •

edited

Loading