Skip to content

Fix Change "Max Result Count" to be applied immediately #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix Change "Max Result Count" to be applied immediately #766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Flow.Launcher.Infrastructure/UserSettings/Settings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace Flow.Launcher.Infrastructure.UserSettings
public class Settings : BaseModel
{
private string language = "en";

private int maxresult = 5;
public string Hotkey { get; set; } = $"{KeyConstant.Alt} + {KeyConstant.Space}";
public string OpenResultModifiers { get; set; } = KeyConstant.Alt;
public bool ShowOpenResultHotkey { get; set; } = true;
Expand Down Expand Up @@ -72,7 +72,14 @@ public string QuerySearchPrecisionString

public double WindowLeft { get; set; }
public double WindowTop { get; set; }
public int MaxResultsToShow { get; set; } = 5;
public int MaxResultsToShow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is fody not working well? It is not supposed that we need a onpropertychanged here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is fody not working well? It is not supposed that we need a onpropertychanged here

I'll search for "fody" and come back.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I understand why fody not working here. Because the infrastructure repo don't include a reference for fody. Let's check whether we want to add fody to that project.
Fody is used to waive the need for writing propertychange in flow. https://github.com/Fody/PropertyChanged

{
get => maxresult; set
{
maxresult = value;
OnPropertyChanged();
}
}
public int ActivateTimes { get; set; }


Expand Down