- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 454
Add width in setting and fix max result displayed not reflected in real-time #767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 18 commits
      Commits
    
    
            Show all changes
          
          
            20 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      02036f1
              
                add width slider
              
              
                onesounds 5938a9d
              
                Merge branch 'FixThemes' into SettingWidth
              
              
                onesounds 616e98a
              
                wip
              
              
                onesounds 6af1262
              
                Adjust Width in Theme.cs
              
              
                onesounds 5e0172c
              
                - Remove Comment
              
              
                onesounds 6b37ada
              
                - Remove Comment
              
              
                onesounds 6aaca10
              
                adjust slider size
              
              
                onesounds 5be44b6
              
                Add fody and use binding to change width
              
              
                taooceros 674d615
              
                Display Querybox when Using Width slider.
              
              
                onesounds 08c643a
              
                Add "IsMoveToPointEnabled" property
              
              
                onesounds 64a489b
              
                Use Hacky way to show up windows when width change.
              
              
                taooceros a83f9df
              
                Revert "Use Hacky way to show up windows when width change."
              
              
                taooceros 9d30960
              
                Bind width to preview
              
              
                taooceros 22fb3f4
              
                Add Preview Height
              
              
                onesounds fe90ebc
              
                Use binding to control MinWidth and MaxWidth
              
              
                taooceros bdcf419
              
                - Move Seperator toggle style to mainwindow xaml (for preview separat…
              
              
                onesounds 0a74766
              
                remove obsolete comment
              
              
                jjw24 09992fa
              
                merge dev for fix conflict
              
              
                onesounds 6498c6b
              
                Merge dev for fix conflict
              
              
                onesounds 8ca8461
              
                Reformat xaml code
              
              
                taooceros File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you remove all the width setting in the theme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't do it yet. Should I?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't this pr done that job? #755
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did so only for the elements inside the window. The themes currently pushed are fixed in window size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok nvm I remember the setter will be override by direct setting the width. Therefore, it shouldn't be a problem.