Merge duplicate weeks spanning across two years (week 53 and week 01) #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3) with first week data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #86, which addressed the formatting issue when week intervals span two years.
Problem
Even with correct week-year formatting, MySQL may return two distinct keys for the same ISO week: for instance, both "2024-53" and "2025-01" can refer to the same 7-day period starting on Monday, December 30, 2024 and ending on Sunday, January 5, 2025.
This leads to:
• Two TrendValue items for the same week, which is incorrect.
• Duplicate data in visual representations, especially line charts, which expect unique and continuous labels on the X-axis.
Fix
This PR merges the two values into a single entry