-
Notifications
You must be signed in to change notification settings - Fork 5
CI: actions checkout update to V5 #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
CI: actions checkout update to V5 #215
Conversation
WalkthroughAll modified GitHub Actions workflows update actions/checkout from v4 to v5. In main.yml, two checkout steps were updated; in the other workflows, a single checkout step was updated. No other workflow logic or configuration changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
.github/workflows/save-activity.yml (1)
16-16
: Upgrade looks good; please pin checkout to a commit SHA (security) and confirm runner compatibility.
- actions/checkout v5 runs on Node 24 and requires Actions Runner v2.327.1+. Hosted runners are fine; verify if any self‑hosted runners are used. (github.com)
- Pin to the v5 release commit to mitigate tag‑hijack risks.
Apply:
- - uses: actions/checkout@v5 + - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.github/workflows/save-article.yml (1)
16-16
: Same here: pin actions/checkout to the v5 commit and verify runner version.
- v5 → Node 24; needs runner v2.327.1+. (github.com)
- Pin to the release commit for supply‑chain safety.
- - uses: actions/checkout@v5 + - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.github/workflows/formatter.yml (1)
10-10
: Pin checkout to a specific v5 commit.
- Prevents executing a moved/malicious tag; v5 commit is 08c6903… (v5.0.0). (github.com)
- - uses: actions/checkout@v5 + - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.github/workflows/fetch-Web.yml (1)
14-14
: Pin checkout and confirm runner meets v5 requirement.
- v5 requires Actions Runner v2.327.1+; pin to the v5 commit. (github.com)
- - uses: actions/checkout@v5 + - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.github/workflows/main.yml (1)
11-11
: Good upgrade; pin to SHA and double‑check external repo access.
- Pin both checkout steps to the v5 commit for supply‑chain safety. (github.com)
- If “Program repository” is private, pass a PAT via the token input; GITHUB_TOKEN is scoped to the current repo. (github.com)
- v5 requires runner v2.327.1+ (okay on hosted). (github.com)
- uses: actions/checkout@v5 + uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5 @@ - uses: actions/checkout@v5 + uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5If the Program repo is private:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5 with: repository: ${{ secrets.GIT_URI }} # must be "owner/repo" token: ${{ secrets.PERSONAL_TOKEN }} ref: hexo path: super/Also applies to: 15-15
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/fetch-Web.yml
(1 hunks).github/workflows/formatter.yml
(1 hunks).github/workflows/main.yml
(1 hunks).github/workflows/save-activity.yml
(1 hunks).github/workflows/save-article.yml
(1 hunks)
@FreeCodeCamp-Chengdu/team-1 I create a Pull Request to close #issue_number
Summary by CodeRabbit