refactor: make CLI transforms shim-first preserve Web Forms API calls#536
Open
csharpfritz wants to merge 1 commit intoFritzAndFriends:devfrom
Open
refactor: make CLI transforms shim-first preserve Web Forms API calls#536csharpfritz wants to merge 1 commit intoFritzAndFriends:devfrom
csharpfritz wants to merge 1 commit intoFritzAndFriends:devfrom
Conversation
WebFormsPageBase provides Request, Response, Server, Session, Cache, ClientScript, IsPostBack, and ViewState as properties. Code inheriting from it compiles AS-IS with no transforms needed for these APIs. Changes: - ResponseRedirectTransform: stop rewriting Response.Redirect() to NavigationManager.NavigateTo(). Leave calls intact ResponseShim handles ~/ and .aspx automatically. Only strip Page./this. prefix. - SessionDetectTransform: remove redundant [Inject] SessionShim and CacheShim injection already on WebFormsPageBase. - ClientScriptTransform: fix guidance to say 'works via WebFormsPageBase' instead of suggesting @Inject (wrong syntax in .cs file). - RequestFormTransform: lead guidance with 'works automatically via RequestShim on WebFormsPageBase'. - ServerShimTransform: lead guidance with 'works automatically via ServerShim on WebFormsPageBase'. All 353 CLI tests pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shim-First CLI Transforms
WebFormsPageBase provides Request, Response, Server, Session, Cache, ClientScript, IsPostBack, and ViewState as properties. Pages inheriting from it compile AS-IS. But 5 CLI transforms were doing unnecessary work:
All 353 CLI tests pass.
Closes #534