-
Notifications
You must be signed in to change notification settings - Fork 97
refactor: cleanup logInfo #3755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR was clearly needed, thanks !
{ | ||
static constexpr int getMinLogLevel() { return 1; } | ||
static constexpr std::string_view getDescription() | ||
{ | ||
return "Output the loaded/computed table data in the log if succinct enough," |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why all the sentence has been simplified, it contained useful information for the user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this specific one was simply wrong, no? nothing to do with csv output which is controlled by a different flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request refactors the logging infrastructure throughout the GEOS codebase by consolidating and standardizing logInfo structures across different modules. The primary purpose is to cleanup and simplify the logging system by removing duplicate and redundant log level definitions, reorganizing them into more coherent categories, and establishing a cleaner hierarchy.
- Consolidates various logInfo structures into more general categories (e.g.,
LinearSolverConfiguration
→LinearSolver
,BoundaryCondition
→BoundaryConditions
) - Removes redundant and module-specific log level definitions in favor of centralized ones
- Updates all logging calls throughout the codebase to use the new consolidated log level names
Reviewed Changes
Copilot reviewed 89 out of 89 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
LogLevelsInfo.hpp files | Consolidates and standardizes log level definitions across modules |
Physics solver files | Updates log level registrations and calls to use new consolidated names |
Output files | Removes specialized timer categories in favor of centralized approach |
Input files | Removes explicit logLevel attributes from field specifications |
CMakeLists.txt | Removes deleted LogLevelsInfo.hpp file references |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.