Skip to content

Conversation

paveltomin
Copy link
Contributor

No description provided.

arng40

This comment was marked as duplicate.

Copy link
Contributor

@arng40 arng40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was clearly needed, thanks !

{
static constexpr int getMinLogLevel() { return 1; }
static constexpr std::string_view getDescription()
{
return "Output the loaded/computed table data in the log if succinct enough,"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why all the sentence has been simplified, it contained useful information for the user

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this specific one was simply wrong, no? nothing to do with csv output which is controlled by a different flag

@paveltomin paveltomin requested a review from Copilot August 15, 2025 20:56
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the logging infrastructure throughout the GEOS codebase by consolidating and standardizing logInfo structures across different modules. The primary purpose is to cleanup and simplify the logging system by removing duplicate and redundant log level definitions, reorganizing them into more coherent categories, and establishing a cleaner hierarchy.

  • Consolidates various logInfo structures into more general categories (e.g., LinearSolverConfigurationLinearSolver, BoundaryConditionBoundaryConditions)
  • Removes redundant and module-specific log level definitions in favor of centralized ones
  • Updates all logging calls throughout the codebase to use the new consolidated log level names

Reviewed Changes

Copilot reviewed 89 out of 89 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
LogLevelsInfo.hpp files Consolidates and standardizes log level definitions across modules
Physics solver files Updates log level registrations and calls to use new consolidated names
Output files Removes specialized timer categories in favor of centralized approach
Input files Removes explicit logLevel attributes from field specifications
CMakeLists.txt Removes deleted LogLevelsInfo.hpp file references

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@paveltomin paveltomin added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Aug 25, 2025
@paveltomin paveltomin merged commit 73c931a into develop Aug 25, 2025
25 of 26 checks passed
@paveltomin paveltomin deleted the pt/cleanup-loginfo branch August 25, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: cleanup / refactor Non-functional change (NFC)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants