Skip to content

Conversation

paveltomin
Copy link
Collaborator

No description provided.

@paveltomin paveltomin self-assigned this Aug 13, 2025
@paveltomin paveltomin added type: feature New feature or request flag: ready for review flag: no rebaseline Does not require rebaseline labels Aug 13, 2025
@paveltomin paveltomin requested a review from cssherman as a code owner August 13, 2025 18:19
@MelReyCG
Copy link
Contributor

MelReyCG commented Aug 19, 2025

I would suggest to add a bit of documentation in src\coreComponents\physicsSolvers\LogLevelsInfo.hpp:

struct SolverExecutionDetails
{
  static constexpr int getMinLogLevel() { return 2; }
  static constexpr std::string_view getDescription() { return "More precise information on solver execution + does output after every cycle."; }
};

@paveltomin
Copy link
Collaborator Author

I would suggest to add a bit of documentation in src\coreComponents\physicsSolvers\LogLevelsInfo.hpp:

struct SolverExecutionDetails
{
  static constexpr int getMinLogLevel() { return 2; }
  static constexpr std::string_view getDescription() { return "More precise information on solver execution + does output after every cycle."; }
};

done

@paveltomin paveltomin removed the request for review from wrtobin August 19, 2025 14:44
@paveltomin paveltomin added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Sep 9, 2025
@paveltomin paveltomin added the ci: run code coverage enables running of the code coverage CI jobs label Sep 10, 2025
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 67.85714% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.41%. Comparing base (315b379) to head (cd99b6e).

Files with missing lines Patch % Lines
src/coreComponents/events/EventManager.cpp 16.66% 5 Missing ⚠️
...oreComponents/physicsSolvers/PhysicsSolverBase.hpp 0.00% 2 Missing ⚠️
...rc/coreComponents/physicsSolvers/LogLevelsInfo.hpp 0.00% 1 Missing ⚠️
...oreComponents/physicsSolvers/PhysicsSolverBase.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3773   +/-   ##
========================================
  Coverage    59.41%   59.41%           
========================================
  Files         1286     1286           
  Lines       111820   111826    +6     
========================================
+ Hits         66437    66441    +4     
- Misses       45383    45385    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paveltomin paveltomin merged commit 4bd6caa into develop Sep 11, 2025
28 checks passed
@paveltomin paveltomin deleted the pt/stats-timestep branch September 11, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants