Skip to content

Conversation

dkachuma
Copy link
Contributor

Fixes a bug introduced in a previous PR. When the mixture is a pure component, we skip the stability test and mark it as single phase. However the incipient phase composition wasn't being assigned leading to a crash down the line. This PR fixes that.

@dkachuma dkachuma self-assigned this Aug 20, 2025
@dkachuma dkachuma added the type: bug Something isn't working label Aug 20, 2025
@dkachuma dkachuma added ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Aug 20, 2025
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.74%. Comparing base (9d92895) to head (117f956).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ompositional/models/NegativeTwoPhaseFlashModel.hpp 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3783      +/-   ##
===========================================
- Coverage    58.74%   58.74%   -0.01%     
===========================================
  Files         1278     1278              
  Lines       110244   110246       +2     
===========================================
  Hits         64766    64766              
- Misses       45478    45480       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkachuma dkachuma added the flag: requires rebaseline Requires rebaseline branch in integratedTests label Aug 20, 2025
@paveltomin paveltomin merged commit 85863a3 into develop Aug 25, 2025
28 checks passed
@paveltomin paveltomin deleted the dkachuma/stability-bypass branch August 25, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants