-
Notifications
You must be signed in to change notification settings - Fork 97
fix: Fix bug in stability test bypass #3783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3783 +/- ##
===========================================
- Coverage 58.74% 58.74% -0.01%
===========================================
Files 1278 1278
Lines 110244 110246 +2
===========================================
Hits 64766 64766
- Misses 45478 45480 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paveltomin
approved these changes
Aug 20, 2025
dkachuma
commented
Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci: run code coverage
enables running of the code coverage CI jobs
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
flag: ready for review
flag: requires rebaseline
Requires rebaseline branch in integratedTests
type: bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in a previous PR. When the mixture is a pure component, we skip the stability test and mark it as single phase. However the incipient phase composition wasn't being assigned leading to a crash down the line. This PR fixes that.