feat: CI - Add code rules checking action #3914
Conversation
arng40
added
type: CI
MelReyCG
changed the title
MelReyCG
left a comment
MelReyCG
left a comment
There was a problem hiding this comment.
I think you showed that script works, but it seems that there are some critical issues in it.
| - name: Check the code rules | ||
| run: "scripts/check_code_rules.sh" |
There was a problem hiding this comment.
Why is it no longer grouped with the code style & docs?
There was a problem hiding this comment.
it's not executed the same way as code style & docs
There was a problem hiding this comment.
So, why isn't it executed the same way? I don't know why the process has to be different than uncrustify check.
And, if it have to remain a job, why isn't check_code_rules in check_that_all_jobs_succeeded? As you're proposing, it is only advisory.
| fi | ||
| done | ||
|
|
||
| EXCLUDE_EXPRESSION=() |
There was a problem hiding this comment.
I'm confused, does it excludes?
There was a problem hiding this comment.
| EXCLUDE_EXPRESSION=() | |
| EXCLUDED_NAMES=() |
| EXCLUDE_EXPRESSION=() | |
| EXCLUDED_NAME_PATTERNS_=() |
MelReyCG
left a comment
MelReyCG
left a comment
There was a problem hiding this comment.
Waiting for the last two comments to be resolved.
This PR aim to create a new CI Target in order to ensure the use of the internal tool in geos and to promote the best coding practice.
First, this PR set up the CI
check_code_rulesand will ensure the use of :stdMap,stdUnorderedMap&stdVectorThis PR will be merged after :