Skip to content

refactor: Move GeosBlockExtractor from geos-posp to geos-mesh #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

refactor: Move GeosBlockExtractor from geos-posp to geos-mesh #142

wants to merge 14 commits into from

Conversation

RomainBaville
Copy link
Contributor

@RomainBaville RomainBaville commented Sep 26, 2025 •
edited
Loading

In the context of the code refactoring, this pr aims to:

  • Move the filter in the correct folder and update import/doc
  • Stop using VTKPythonAlgorithmBase as mother class of the filter
  • Implement a child class of vtkExtractBlock to extract geos domain directly
  • Implement a test file for the filter.

Note: A future pr will clean all the test mesh

@RomainBaville RomainBaville self-assigned this Sep 26, 2025
@RomainBaville RomainBaville marked this pull request as ready for review October 15, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jafranc jafranc Awaiting requested review from jafranc

@paloma-martinez paloma-martinez Awaiting requested review from paloma-martinez

@alexbenedicto alexbenedicto Awaiting requested review from alexbenedicto

At least 1 approving review is required to merge this pull request.

Assignees

@RomainBaville RomainBaville

Labels

flag: ready for review type: refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RomainBaville