refactor: mesh-doctor Convert snake_case to camelCase & Update old formatted function docString #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
alexbenedicto
requested review from
RomainBaville,
jafranc and
paloma-martinez
There was a problem hiding this comment.
Tanks for the change of style to camelCase.
You also change the typing style using the update of the python 3.9. There is still here and there the old way but I think using the old way is easer to read. There is a particular reason to use the new typing ?
Moreover, some files especialy test files don't have hader, can you set the license and the copyright ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to perform the first 2 tasks of #145 to create a mesh-doctor package.
This PR also closes the PR #143 which code is going to be added after the mesh-doctor package was created.
vtkIO was also modified using the code of PR #143 and applying the reviews suggested.