feat: add logic to intersect cell with a box in geos-trame #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbenedicto
changed the title
lucas-givord
force-pushed
the
lgivord/feature/add_intersection_with_box
branch
from
00cd011 to
56878ff
Compare
|
@lucas-givord See #118 to understand the change in geos-trame pyproject,toml |
Previously user needs to trigger a render call to fix a bad scalar array/lut when a new data was added in the pyvista.Plotter. We enforce it when we trigger the 'update_viewer' method.
lucas-givord
force-pushed
the
lgivord/feature/add_intersection_with_box
branch
from
e9f194a to
5b56754
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support to render a Box. It also add support to render intersected cell in this box.
close #85
this PR depends on #96.