Skip to content

Rework to store-r2d2 and add fetch_from_r2d2 - #876

Open
mranst wants to merge 28 commits into
developfrom
feature/mranst/skip_store_r2d2
Open

Rework to store-r2d2 and add fetch_from_r2d2#876
mranst wants to merge 28 commits into
developfrom
feature/mranst/skip_store_r2d2

Conversation

@mranst

@mranst mranst commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Description

Reworks --skip-r2d2 to have the opposite behavior, now --store-r2d2 has to be set to enable registering and storing the experiment in r2d2.

Adds key that controls whether to fetch obs from r2d2. This replaces the default behavior of waiting for fail from GetObsNotInR2d2. This key is only implemented in atmos suites, for now.

@mranst
mranst marked this pull request as ready for review August 21, 2026 20:31
@mranst

mranst commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

fyi - this will of course require changing --skip-r2d2 to --skip-store-r2d2 in any existing scripts (-k is maintained)

@mer-a-o

mer-a-o commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@mranst great addition! I think there are some inconsistencies for skip-store-r2d2 vs skip_store_r2d2 in this PR.
I tested swell create hofx_cf --skip-store-r2d2 and the experiment worked as expected. Also, 3dvar_atmos works correctly too.

@mranst

mranst commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

@mranst great addition! I think there are some inconsistencies for skip-store-r2d2 vs skip_store_r2d2 in this PR. I tested swell create hofx_cf --skip-store-r2d2 and the experiment worked as expected. Also, 3dvar_atmos works correctly too.

Yeah, it's a discrepancy between POSIX-style formatting for command line flags --skip-store-r2d2 vs python syntax skip_store_r2d2

Comment thread docs/introduction/quickstart.md Outdated
mer-a-o
mer-a-o previously approved these changes Aug 25, 2026
@Dooruk

Dooruk commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

I don't have a chance to test this before I leave tomorrow but I'm wondering if we should have the skip_store defaulting True.

Tiered tests are filling up the swell project space until we figure out the scrubber.

@mranst

mranst commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

I don't have a chance to test this before I leave tomorrow but I'm wondering if we should have the skip_store defaulting True.

Tiered tests are filling up the swell project space until we figure out the scrubber.

This is fine with me, I usually set false anyway

@mranst mranst changed the title Rework skip-store-r2d2 and add fetch_from_r2d2 Rework to store-r2d2 and add fetch_from_r2d2 Aug 28, 2026
@mranst

mranst commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator Author

I've changed this so that instead of storing by default, now --store-r2d2 needs to be enabled. -k has been left in place with a deprecation warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants