Ci misc improvements #295
Closed
Ci misc improvements #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDL event loop. Added some comments to clarify behavior.
Number formatting: fix key events handling
|
wrong branch. decided it was easier to start over (#296) than rebase. |
|
You could force push it here, but does not matter, there are not that many PRs here, so looks cooler when we have higher PR ids 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General improvements/cleanup of CI to address things such as #285 (comment). Will include misc refactoring/features, e.g. an image diff (
ssimis useful but is a global metric).Currently a WIP. Making a pull-request to trigger tests. If you have any ideas/suggestions feel free to share.