Skip to content

Set appropriate window application and titles instead of defaulting to gsconnect #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −3
Open

Set appropriate window application and titles instead of defaulting to gsconnect #1875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7714746
Set appropriate window titles instead of defaulting to gsconnect or G…
sidevesh Oct 13, 2024
1b1e88a
Fix messaging constructor
sidevesh Oct 13, 2024
e96ace7
Add Gio import and remove passing title to constructors
sidevesh Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/service/plugins/findmyphone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ const Dialog = GObject.registerClass({
}, class Dialog extends Gtk.MessageDialog {
_init(params) {
super._init({
application: Gio.Application.get_default(),
buttons: Gtk.ButtonsType.CLOSE,
device: params.device,
image: new Gtk.Image({
Expand Down
6 changes: 4 additions & 2 deletions src/service/ui/messaging.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// SPDX-License-Identifier: GPL-2.0-or-later

import Gdk from 'gi://Gdk';
import Gio from 'gi://Gio';
import GLib from 'gi://GLib';
import GObject from 'gi://GObject';
import Gtk from 'gi://Gtk';
Expand Down Expand Up @@ -833,7 +834,9 @@ export const Window = GObject.registerClass({
}, class MessagingWindow extends Gtk.ApplicationWindow {

_init(params) {
super._init(params);
super._init(Object.assign({
application: Gio.Application.get_default(),
}, params));
this.headerbar.subtitle = this.device.name;

this.insert_action_group('device', this.device);
Expand Down Expand Up @@ -1317,4 +1320,3 @@ export const ConversationChooser = GObject.registerClass({
this.destroy();
}
});

2 changes: 2 additions & 0 deletions src/service/ui/mousepad.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
//
// SPDX-License-Identifier: GPL-2.0-or-later

import Gio from 'gi://Gio';
import GLib from 'gi://GLib';
import Gdk from 'gi://Gdk';
import GObject from 'gi://GObject';
Expand Down Expand Up @@ -100,6 +101,7 @@ export const InputDialog = GObject.registerClass({

_init(params) {
super._init(Object.assign({
application: Gio.Application.get_default(),
use_header_bar: true,
}, params));

Expand Down
1 change: 0 additions & 1 deletion src/service/ui/service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,4 +249,3 @@ export const ErrorDialog = GObject.registerClass({
return uri;
}
});