Merged
Conversation
Update the header keywords to follow the naming convention from Euclid. The output file names has also been updated to follow the Euclid naming with some modifications: The format for the VIS single exposure is: `EUC_VIS_SWL_DET-[ObsId]-[Dither]-[exposure]-0000000__[YYYYMMDDThhmmss.s]Z.fits` which has been changed to: `EUC_ELSIM_SWL_DET-[ObsId]-[Dither]-[exposure]-[CCD_number]__[YYYYMMDDThhmmss.s]Z.fits` where `ELSIM` stand for: "Euclid-Like Simulation"
rmandelb
reviewed
Apr 24, 2025
Member
rmandelb
left a comment
rmandelb
left a comment
There was a problem hiding this comment.
Do we provide documentation of the various output files, their headers, and a schema for those with catalog data? If not, we should set that up at some point, but it can be opened as a separate issue
config/was.yaml
Outdated
| file_name: | ||
| type: FormattedStr | ||
| format: "Euclidlike_WAS_truth_%s_%i_%i.noise.fits.gz" | ||
| format: "EUC_ELSIM_SWL_VAR-%s-%s-1-%s__%sZ.fits" |
Member
There was a problem hiding this comment.
This is one that we discussed renaming just now
config/was.yaml
Outdated
| file_name: | ||
| type: FormattedStr | ||
| format: "Euclidlike_WAS_index_%s_%i_%i.txt" | ||
| format: "EUC_ELSIM_SWL_WGT-%s-%s-1-%s__%sZ.txt" |
Member
There was a problem hiding this comment.
I think this one was also discussed to rename
euclidlike/instrument_params.py
Outdated
| vis_red_limit = 910 | ||
|
|
||
| # Coadd info | ||
| coadd_zeropoint = 23.9 # Euclid zero-point in AB mag, used in all bands |
Member
There was a problem hiding this comment.
I realize it may seem silly but it would also be good to document the source for this
rmandelb
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the header keywords to follow the naming convention from Euclid. The output file names has also been updated to follow the Euclid naming with some modifications:
The format for the VIS single exposure is:
EUC_VIS_SWL_DET-[ObsId]-[Dither]-[exposure]-0000000__[YYYYMMDDThhmmss.s]Z.fitswhich has been changed to:EUC_ELSIM_SWL_DET-[ObsId]-[Dither]-[exposure]-[CCD_number]__[YYYYMMDDThhmmss.s]Z.fitswhereELSIMstand for: "Euclid-Like Simulation"The ref for the header keywords and file names: http://st-dm.pages.euclid-sgs.uk/data-product-doc/dmq1/visdpd/dpcards/vis_calibratedquadframe.html#viscalibratedquadframe
This should address: #113 #49