Refactor encoders #1583
Open
Refactor encoders #1583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix code style and python 3 compatibility, reduce code duplication.
Lots of whitespace changes. Best to view with git diff -w
|
I know you put a lot of effort into refactoring the ARM encoders, but I'm hesitant to do so without working tests (since the encoders have all been broken for some time). All of the code was lifted from an academic paper, so any diversion from that is a maintenance burden. |
|
Agree with @zachriggle it would be nice to get the encoders working and tested before refactoring / rewriting them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes to ARM alphanumeric (reduced duplication and fixed indentation).