Skip to content

Conversation

seisman
Copy link
Member

@seisman seisman commented Aug 24, 2025

In Figure.text, when position is given, text is required. If text is not given, it should raise a GMTParameterError (i.e., #4003). If text is a list/tuple, it should raise the GMTTypeError instead.

This PR makes the change and raise GMTTypeError when a list/tuple is passed to text.

@seisman seisman added this to the 0.17.0 milestone Aug 24, 2025
@seisman seisman added maintenance Boring but important stuff for the core devs needs review This PR has higher priority and needs review. labels Aug 24, 2025
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. final review call This PR requires final review and approval from a second reviewer labels Aug 25, 2025
@seisman seisman merged commit 9c42f50 into main Aug 25, 2025
29 of 30 checks passed
@seisman seisman deleted the text/fix-msg branch August 25, 2025 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants