chore: update thrash candidates 2026-08-21

[ben-versluis]

Summary

Updates snapshots/e2e-nightly-metrics.json with the current E2E test thrash-detection results (60-day lookback across the QA project's nightly POS/Back Office triage tickets).

• 43 confirmed thrash candidates (tests fixed 2+ times with verified merged/attempted PR evidence), 24 POS / 19 Back Office
• 8 ESCALATE, 9 REDESIGN, 26 INVESTIGATE
• Most-thrashed: [654086] "User should be able to transfer" (Back Office) — fixed 11 times over 8 weeks
• Every PR reference was independently verified via gh pr view (not taken from ticket text alone), which surfaced two data-quality findings baked into this update:
  • Several tests previously counted as "fixed" were actually parking-section artifacts in the source tickets (e.g. Pay-By-Bank error tests) — excluded from this list.
  • 12 of 33 PRs touching thrash-candidate tests were closed without merging, and 2 have sat open 30+ days — meaning several "fixed" tickets didn't actually ship a fix.

Full narrative report (fix-history tables, pattern analysis, root-cause hypotheses per cluster) was posted to #skipped-test-automation.

Test plan

• Confirm dashboard at https://vape-pages.dutchie.dev/e2e-nightly-metrics/ renders the updated thrash_candidates array correctly after merge
• Spot-check a couple of PR links (e.g. #8394, #7236) resolve correctly