feat: show delivery status and read status on the message and channel preview #3258
Conversation
SDK Size
|
examples/SampleApp/index.js
Outdated
| import 'react-native-gesture-handler'; | ||
| import { AppRegistry } from 'react-native'; | ||
| import { enableScreens } from 'react-native-screens'; | ||
| import './src/utils/bootstrapBackgroundMessageHandler'; |
There was a problem hiding this comment.
Move this before RNGH and all of the other imports please, it's important that the very first thing encountered whenever App.tsx is hit is the bootstrapping
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> |
There was a problem hiding this comment.
Please revert these changes when you can, they do not seem correct
There was a problem hiding this comment.
Well they are just the same with different indentation. This is a change that I open get on my system while opening Xcode and adding a setting. But, i will revert it back
| const areEqual = (prevProps: MessagePropsWithContext, nextProps: MessagePropsWithContext) => { | ||
| const { | ||
| chatContext: { mutedUsers: prevMutedUsers }, | ||
| deliveredBy: prevDeliveredBy, |
There was a problem hiding this comment.
Shouldn't this be deliveredTo or deliveredToCount or something similar ?
There was a problem hiding this comment.
I will change it to deliveredToCount
|
|
||
| export const MessageStatus = (props: MessageStatusProps) => { | ||
| const { message, readBy, threadList } = useMessageContext(); | ||
| const { channel } = useChannelContext(); |
There was a problem hiding this comment.
Since we're only really using the channel to see if the members length is greater than 2, perhaps we could precalculate this elsewhere and just pass it to be used as an atomic value ? That way we won't have to worry about unstable references changing (nor probably need to run useChannelContext() like this downstream (which will trigger many changes). Having it here pre-memoization is definitely an improvement but we can still move it outside since we were anyway never passing it as a prop so it isn't breaking either.
There was a problem hiding this comment.
Well we do have channel as a direct prop to the MessageStatus component so I am not sure if we can do that.
There was a problem hiding this comment.
Apart from the couple of comments I don't have any other concrete objections ! We have to refactor the ChannelPreview at some point, it feels like it's slowly getting out of hand and it could use some love.
Please profile the PR on both platforms to make sure we aren't degrading performance further (it doesn't look like it at first glance, but let's be sure of it)
3 participants
This pull request introduces significant improvements to message delivery status tracking and notification handling in the sample app and core package. The main focus is on refactoring how message delivery status is determined and displayed in channel previews, as well as improving notification handling for both foreground and background messages. The changes include a new hook for message delivery status, updates to type usage for better consistency, and improved notification display logic.
Message Delivery Status Refactor:
useMessageDeliveryStatushook to determine and track the delivery status (SENT,DELIVERED,READ, orNOT_SENT_BY_CURRENT_USER) of the latest message in a channel, replacing the previous read status logic. This makes the status handling more granular and accurate.useLatestMessagePreviewand related components to use the newMessageDeliveryStatusenum and hook, and refactored related types to useLocalMessagefor better type safety and clarity.Notification Handling Improvements:
displayNotificationutility to handle notification display logic in both foreground and background, reducing code duplication and improving maintainability.bootstrapBackgroundMessageHandler.ts) that initializes the chat client, marks messages as delivered, and displays notifications when messages are received in the background.General Code Quality and Consistency:
LocalMessagefor consistency and reliability.These changes collectively improve the reliability and user experience of message delivery indicators and push notifications in the application.