V5: Use web-socket client from StreamCore #3861
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Generated by 🚫 Danger |
…tion" This reverts commit 7e38507.
SDK Performance
|
laevandus
commented
Oct 31, 2025
| set { connectionQueue.async(flags: .barrier) { self._connectionId = newValue }} | ||
| } | ||
|
|
||
| let webSocketConnectEndpoint = AllocatedUnfairLock<Endpoint<EmptyResponse>?>(nil) |
There was a problem hiding this comment.
Endpoint used to be in WebSocketClient, but the one from StreamCore does not use endpoint type, so this logic was moved to here.
There was a problem hiding this comment.
yes, and it would make it easier to migrate away from endpoints to generated code.
laevandus
commented
Oct 31, 2025
Comment on lines
+148
to
+152
| let event = ConnectionStatusUpdated(webSocketConnectionState: state) | ||
| if event.connectionStatus != connectionStatus { | ||
| // Publish Connection event with the new state | ||
| webSocketClient?.publishEvent(event) | ||
| } |
There was a problem hiding this comment.
Used to be in WebSocketClient. Since this is a custom event, I left it here instead.
laevandus
commented
Oct 31, 2025
Comment on lines
+164
to
+166
| syncRepository.syncLocalState { | ||
| log.info("Local state sync completed", subsystems: .offlineSupport) | ||
| } |
There was a problem hiding this comment.
Was in WebSocketClient, now it is here
There was a problem hiding this comment.
yes, this is chat specific logic
laevandus
commented
Oct 31, 2025
|
|
||
| /// The type is designed to pre-process some incoming `Event` via middlewares before being published | ||
| class EventNotificationCenter: NotificationCenter, @unchecked Sendable { | ||
| class PersistentEventNotificationCenter: NotificationCenter, EventNotificationCenter, @unchecked Sendable { |
There was a problem hiding this comment.
Easier to have a different type than trying to migrate this to StreamCore.
martinmitrevski
approved these changes
Oct 31, 2025
| set { connectionQueue.async(flags: .barrier) { self._connectionId = newValue }} | ||
| } | ||
|
|
||
| let webSocketConnectEndpoint = AllocatedUnfairLock<Endpoint<EmptyResponse>?>(nil) |
There was a problem hiding this comment.
yes, and it would make it easier to migrate away from endpoints to generated code.
Comment on lines
+148
to
+152
| let event = ConnectionStatusUpdated(webSocketConnectionState: state) | ||
| if event.connectionStatus != connectionStatus { | ||
| // Publish Connection event with the new state | ||
| webSocketClient?.publishEvent(event) | ||
| } |
Comment on lines
+164
to
+166
| syncRepository.syncLocalState { | ||
| log.info("Local state sync completed", subsystems: .offlineSupport) | ||
| } |
There was a problem hiding this comment.
yes, this is chat specific logic
nuno-vieira
approved these changes
Oct 31, 2025
SDK Size
|
StreamChat XCSize
Show 231 more objects
|
StreamChatUI XCSize
Show 292 more objects
|
Public Interface- public enum ConnectionStatus: Equatable, Sendable
-
- case initialized
- case disconnected(error: ClientError? = nil)
- case connecting
- case connected
- case disconnecting
- public protocol Event: Sendable
- public struct APIKey: Equatable, Sendable
-
- public let apiKeyString: String
-
-
- public init(_ apiKeyString: String)
- public final class IgnoredEventType: ClientError, @unchecked Sendable
-
- override public var localizedDescription: String
public final class HealthCheckEvent: ConnectionEvent, EventDTO, Sendable
+
+
+ public func healthcheck()-> HealthCheckInfo? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Fixes IOS-1205
🎯 Goal
Use WebSocketClient from StreamCore which has slightly different interface
📝 Summary
Provide bullet points with the most important changes in the codebase.
🛠 Implementation
Provide a detailed description of the implementation and explain your decisions if you find them relevant.
🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
🧪 Manual Testing Notes
Explain how this change can be tested manually, if applicable.
☑️ Contributor Checklist
docs-contentrepo