Skip to content

Fix race condition in WebSocketClient connection handling #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix race condition in WebSocketClient connection handling #781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions Sources/StreamVideo/StreamVideo.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,24 +488,13 @@ public class StreamVideo: ObservableObject, @unchecked Sendable {
} else {
throw ClientError.Unknown()
}
var connected = false
var timeout = false
let control = DefaultTimer.schedule(timeInterval: 30, queue: .sdk) {
timeout = true
}
log.debug("Listening for WS connection")
webSocketClient?.onConnected = {
control.cancel()
connected = true
let subject = PassthroughSubject<Void, Error>()
webSocketClient?.onConnected = { subject.send(()) }
do {
try await subject.nextValue(timeout: 30)
log.debug("WS connected")
}

while (!connected && !timeout) {
try await Task.sleep(nanoseconds: 100_000)
}

if timeout {
log.debug("Timeout while waiting for WS connection opening")
} catch {
throw ClientError.NetworkError()
}
}
Expand Down