[Enhancement]Recording permission prompt #915

ipavlidakis · 2025-08-19T14:15:40Z

🔗 Issue Links

Resolves https://linear.app/stream/issue/IOS-1080/recording-permission-prompt

Docs link

https://github.com/GetStream/docs-content/pull/564

🎯 Goal

Prompt user when they haven't accepted the microphone access permission.

🛠 Implementation

This revision centralise permission read across the SDK. The new PermissionStore component is exposed via InjectedValues[.permissions] and offers access and reactivity around microphone, camera and push notifications permissions.

🎨 Showcase

Before	After
`img`

🧪 Manual Testing Notes

From settings disable either/or microphone and camera access
Run the app
Confirm you are seeing the prompt
Interact with it
Confirm it works as expected

☑️ Contributor Checklist

I have signed the Stream CLA (required)
This change follows zero ⚠️ policy (required)
This change should receive manual QA
Changelog is updated with client-facing changes
New code is covered by unit tests
Comparison screenshots added for visual changes
Affected documentation updated (tutorial, CMS)

github-actions · 2025-08-19T14:17:19Z

	1 Warning
⚠️	Big PR

Generated by 🚫 Danger

github-actions · 2025-08-19T14:17:37Z

Public Interface

+ extension PermissionStore: InjectionKey  
+ 
+   nonisolated public static var currentValue: PermissionStore

+ public final class PermissionStore: ObservableObject, @unchecked Sendable  
+ 
+   @Published public private var hasMicrophonePermission: Bool
+   @Published public private var hasCameraPermission: Bool
+   
+ 
+   public func requestMicrophonePermission()async throws -> Bool
+   public func requestCameraPermission()async throws -> Bool
+   public func requestPushNotificationPermission(with options: UNAuthorizationOptions)async throws -> Bool

+ public protocol URLNavigating

+ public enum Permission: Equatable, Sendable, CustomStringConvertible  
+ 
+   case unknown
+   case requesting
+   case denied
+   case granted
+   
+ 
+   public var description: String

+ public enum StoreAction: Sendable, Equatable  
+ 
+   case setMicrophonePermission(Permission)
+   case requestMicrophonePermission
+   case setCameraPermission(Permission)
+   case requestCameraPermission
+   case setPushNotificationPermission(Permission)
+   case requestPushNotificationPermission(UNAuthorizationOptions)

+ public struct StoreState: Equatable, CustomStringConvertible  
+ 
+   public var microphonePermission: Permission
+   public var cameraPermission: Permission
+   public var pushNotificationPermission: Permission
+   public var description: String

+ public struct ToggleControlStyle  
+ 
+   public var enabled: ControlStyle
+   public var disabled: ControlStyle
+   
+ 
+   public init(enabled: ControlStyle,disabled: ControlStyle)

+ public struct PermissionsPromptView: View  
+ 
+   public var body: some View
+   
+ 
+   public init(call: Call?)

+ public struct ControlStyle  
+ 
+   public var icon: Image
+   public var iconStyle: CallIconStyle
+   
+ 
+   public init(icon: Image,iconStyle: CallIconStyle)



 extension ViewFactory  
+   public func makePermissionsPromptView(call: Call?)-> some View

 public struct StatelessMicrophoneIconView: View  
-   public var body: some View
+   public var controlStyle: ToggleControlStyle
-   
+   public var body: some View
- 
+   
-   @MainActor public init(call: Call?,size: CGFloat = 44,actionHandler: ActionHandler? = nil)
+ 
+   @MainActor public init(call: Call?,callSettings: CallSettings = .init(),size: CGFloat = 44,controlStyle: ToggleControlStyle = .init(
+             enabled: .init(icon: Appearance.default.images.micTurnOn, iconStyle: .transparent),
+             disabled: .init(icon: Appearance.default.images.micTurnOff, iconStyle: .disabled)
+         ),actionHandler: ActionHandler? = nil)

 extension InjectedValues  
-   public var pictureInPictureAdapter: StreamPictureInPictureAdapter
+   public var urlNavigator: URLNavigating

 public struct StatelessVideoIconView: View  
-   public var body: some View
+   public var controlStyle: ToggleControlStyle
-   
+   public var body: some View
- 
+   
-   public init(call: Call?,size: CGFloat = 44,actionHandler: ActionHandler? = nil)
+ 
+   public init(call: Call?,callSettings: CallSettings = .init(),size: CGFloat = 44,controlStyle: ToggleControlStyle = .init(
+             enabled: .init(icon: Appearance.default.images.videoTurnOn, iconStyle: .transparent),
+             disabled: .init(icon: Appearance.default.images.videoTurnOff, iconStyle: .disabled)
+         ),actionHandler: ActionHandler? = nil)

 public struct CallTopView: View  
-   public init(viewModel: CallViewModel)
+   public init(viewFactory: Factory = DefaultViewFactory.shared,viewModel: CallViewModel)

 public struct ControlBadgeView: View  
-   public var body: some View
+   case text(String, foreground: Color, background: Color)
-   
+   case image(Image, foreground: Color, background: Color)
- 
+   
-   public init(_ value: String)
+ 
+   public var body: some View
+   
+ 
+   public init(_ value: String,foreground: Color = InjectedValues[\.colors].textInverted,background: Color = InjectedValues[\.colors].onlineIndicatorColor)
+   public init(_ image: Image,foreground: Color = InjectedValues[\.colors].textInverted,background: Color = InjectedValues[\.colors].onlineIndicatorColor)

Stream-SDK-Bot · 2025-08-19T14:24:13Z

SDK Size

`title`	`develop`	`branch`	`diff`	`status`
StreamVideo	8.43 MB	8.48 MB	+43 KB	🟢
StreamVideoSwiftUI	2.29 MB	2.36 MB	+67 KB	🟢
StreamVideoUIKit	2.41 MB	2.48 MB	+68 KB	🟢
StreamWebRTC	9.85 MB	9.85 MB	0 KB	🟢

ipavlidakis · 2025-08-20T16:09:52Z

Sources/StreamVideoSwiftUI/CallView/VideoParticipantsView.swift

@@ -380,15 +381,23 @@ public struct VideoCallParticipantView<Factory: ViewFactory>: View {
    }

    private var showVideo: Bool {
-        participant.shouldDisplayTrack || customData["videoOn"]?.boolValue == true
+        if isLocalParticipant {


This is actually improving the logic on showing the placeholder (user avatar) when video is off for localparticipant.

did we merge the customData change? Wasn't this handled there?

The change from #921 was initially in this branch and had reference to it. I was waiting for a decision on #921 to know if i should rebase or revert. I have now updated this PR with develop.

martinmitrevski

Looks great! Left few small comments, most important is to check if we consider the case where we don't need camera permission (maybe we do, but might've missed it).

...s/StreamVideo/Utils/PermissionsStore/Namespace/Components/MicrophonePermissionProvider.swift

Sources/StreamVideo/Utils/PermissionsStore/PermissionsStore.swift

Sources/StreamVideoSwiftUI/CallView/PermissionsPromptView.swift

martinmitrevski · 2025-08-27T08:00:07Z

Sources/StreamVideoSwiftUI/CallView/VideoParticipantsView.swift

@@ -380,15 +381,23 @@ public struct VideoCallParticipantView<Factory: ViewFactory>: View {
    }

    private var showVideo: Bool {
-        participant.shouldDisplayTrack || customData["videoOn"]?.boolValue == true
+        if isLocalParticipant {


did we merge the customData change? Wasn't this handled there?

Improvements Improve participant placeholder

sonarqubecloud · 2025-08-28T09:51:34Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
74.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ipavlidakis self-assigned this Aug 19, 2025

ipavlidakis added the enhancement New feature or request label Aug 19, 2025

ipavlidakis force-pushed the enhancement/recording-permission-prompt branch 3 times, most recently from b08dc1a to c7ed68c Compare August 20, 2025 16:08

ipavlidakis commented Aug 20, 2025

View reviewed changes

ipavlidakis force-pushed the enhancement/recording-permission-prompt branch from c7ed68c to ea3a174 Compare August 26, 2025 09:36

ipavlidakis marked this pull request as ready for review August 26, 2025 09:42

ipavlidakis requested a review from a team as a code owner August 26, 2025 09:42

martinmitrevski reviewed Aug 27, 2025

View reviewed changes

ipavlidakis force-pushed the enhancement/recording-permission-prompt branch from 97af53f to ca9c696 Compare August 27, 2025 11:57

martinmitrevski approved these changes Aug 27, 2025

View reviewed changes

ipavlidakis added 7 commits August 27, 2025 17:43

PermissionsStore implementation

9534e74

Improvements Improve participant placeholder

Add tests and localisations

d943ddb

Add comments

fd74795

Only show prompt for required permissions

0d654c7

Make promptView configurable

438b8f9

Add cookbook tests

2b52212

Fix compilation error

1a44cba

ipavlidakis force-pushed the enhancement/recording-permission-prompt branch from 3b89b1c to 1a44cba Compare August 27, 2025 14:45

ipavlidakis added 3 commits August 27, 2025 18:39

Make SwiftGen not failing the build

dd7cb60

Update timings in tests

a7b21a4

Fix flakiness in ests

261d0aa

ipavlidakis merged commit 1a37c2c into develop Aug 28, 2025
12 checks passed

ipavlidakis deleted the enhancement/recording-permission-prompt branch August 28, 2025 10:44

ipavlidakis mentioned this pull request Sep 1, 2025

1.32.0 Release #927

Closed

Stream-SDK-Bot mentioned this pull request Sep 8, 2025

1.32.0 Release #937

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Enhancement]Recording permission prompt #915

[Enhancement]Recording permission prompt #915

Uh oh!

ipavlidakis commented Aug 19, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 19, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 19, 2025 •

edited

Loading

Uh oh!

Stream-SDK-Bot commented Aug 19, 2025 •

edited

Loading

Uh oh!

ipavlidakis Aug 20, 2025

Uh oh!

martinmitrevski Aug 27, 2025

Uh oh!

ipavlidakis Aug 27, 2025

Uh oh!

martinmitrevski left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

martinmitrevski Aug 27, 2025

Uh oh!

sonarqubecloud bot commented Aug 28, 2025

Uh oh!

Uh oh!

Uh oh!

[Enhancement]Recording permission prompt #915

[Enhancement]Recording permission prompt #915

Uh oh!

Conversation

ipavlidakis commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Issue Links

Docs link

🎯 Goal

🛠 Implementation

🎨 Showcase

🧪 Manual Testing Notes

☑️ Contributor Checklist

Uh oh!

github-actions bot commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Public Interface

Uh oh!

Stream-SDK-Bot commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Size

Uh oh!

ipavlidakis Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

martinmitrevski Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

ipavlidakis Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

martinmitrevski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

martinmitrevski Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Aug 28, 2025

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

ipavlidakis commented Aug 19, 2025 •

edited

Loading

github-actions bot commented Aug 19, 2025 •

edited

Loading

github-actions bot commented Aug 19, 2025 •

edited

Loading

Stream-SDK-Bot commented Aug 19, 2025 •

edited

Loading