Skip to content

Updated fixme.java #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions fixme.java
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
public class FibonacciChallenge {

public static void main(String[] args) {
// Fix me: Should we allow negative numbers as input?
System.out.println("Fibonacci(5) = " + fibonacci(5));
System.out.println("Fibonacci(10) = " + fibonacci(10));

// Fix me: What happens with this test case?
System.out.println("First 8 Fibonacci numbers:");
printFibonacciSequence(8);

Expand All @@ -14,34 +12,40 @@ public static void main(String[] args) {
}

public static int fibonacci(int n) {
// Fix me: Remember, Fibonacci sequence starts with 0, 1, ...

if (n == 0) {
return 0;
}
if (n == 1) {
return 1;
}
return fibonacci(n - 1) + fibonacci(n - 2);
}

public static void printFibonacciSequence(int n) {
// Fix me: Off-by-one error?
for (int i = 1; i <= n; i++) {
for (int i = 0; i < n; i++) {
System.out.print(fibonacci(i) + " ");
}
System.out.println();
}

public static int efficientFibonacci(int n) {
// Fix me: How can you avoid recalculating the same Fibonacci numbers repeatedly?
int a = 0;
int b = 1;

if (n == 0) {
return a;
return 0;
}
if (n == 1) {
return 1;
}

for (int i = 2; i < n; i++) {
int temp = a;
int a = 0;
int b = 1;

for (int i = 2; i <= n; i++) {
int temp = a + b;
a = b;
b = temp + a;
b = temp;
}

return b;
}
}