Skip to content

Fix bug gitstudenthub java fixme.java #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions fixme.java
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
public class FibonacciChallenge {

public static void main(String[] args) {
// Fix me: Should we allow negative numbers as input?
System.out.println("Fibonacci(5) = " + fibonacci(5));
System.out.println("Fibonacci(10) = " + fibonacci(10));

// Fix me: What happens with this test case?
System.out.println("First 8 Fibonacci numbers:");
printFibonacciSequence(8);

Expand All @@ -14,34 +12,35 @@ public static void main(String[] args) {
}

public static int fibonacci(int n) {
// Fix me: Remember, Fibonacci sequence starts with 0, 1, ...

return fibonacci(n - 1) + fibonacci(n - 2);
if (n < 0) {
throw new IllegalArgumentException("Fibonacci is not defined for negative numbers");
}// Added a throw for negative inputs.

if (n == 0) return 0; // Base case for n = 0
if (n == 1) return 1; // Base case for n = 1
return fibonacci(n - 1) + fibonacci(n - 2); // Recursive call
}

public static void printFibonacciSequence(int n) {
// Fix me: Off-by-one error?
for (int i = 1; i <= n; i++) {
// changes i= 1 to i= 0
for (int i = 0; i <= n; i++) {
System.out.print(fibonacci(i) + " ");
}
System.out.println();
}

public static int efficientFibonacci(int n) {
// Fix me: How can you avoid recalculating the same Fibonacci numbers repeatedly?
int a = 0;
int b = 1;

if (n == 0) {
return a;
}

for (int i = 2; i < n; i++) {
int a = 0, b = 1;

if (n == 0) return a;
if (n == 1) return b;

for (int i = 2; i <= n; i++) { // Use <= instead of <
int temp = a;
a = b;
b = temp + a;
}

return b;
}
}
2 changes: 1 addition & 1 deletion fixme.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ def fibonacci_iterative(n):
return b # Fix me.

n = 10
print(f"The {n}th Fibonacci number is: {fibonacci_iterative(n)}")
print(f"The {n}th Fibonacci number is: {fibonacci_iterative(n)}")