Support translations and generic variants together #3772
Merged
+270
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add rudimentary support for translations & generic variants to be used on the same site. - Refactor `withVariants` into a `variants` object that contains two arrays for the different types: `translations` and `generic`. - Switch the logic around to check these two arrays independently of each other. - If there are any translations (spaces with a different language than the current), the menu dropdown is shown. If there are any generic variants (spaces with the same language as the current), the variant dropdown is shown.
🦋 Changeset detectedLatest commit: e2cd991 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
taranvohra
approved these changes
Oct 30, 2025
zenoachtig
deleted the
support-translations-and-generic-variants-together
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rudimentary support for translations & generic variants to be used on the same site. The variant dropdown on the left and translation dropdown in the header can now function independently from each other.
withVariantsinto avariantsobject that contains two arrays for the different types:translationsandgeneric.