feat(web_feature_consumer): Add parser for V3 web-features data #1745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The web-features data format is being updated to version 3. This new version changes the structure of the `features` object to support different kinds of feature entries: `feature`, `moved`, and `split`, identified by a `kind` property. This commit introduces a new `V3Parser` to handle this new format. It uses a discriminated union pattern by first peeking at the `kind` property of each feature and then unmarshalling the JSON into the corresponding Go struct. The existing parser for the V2 format has been preserved to handle older data formats. Additionally, comprehensive tests for the new V3 parsing logic have been added to ensure correctness. The V3 tests, where real data is fetched, are currently skipped as the v3.0.0 release is not yet available.
jrobbins
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The web-features data format is being updated to version 3. This new version changes the structure of the
featuresobject to support different kinds of feature entries:feature,moved, andsplit, identified by akindproperty.This commit introduces a new
V3Parserto handle this new format. It uses a discriminated union pattern by first peeking at thekindproperty of each feature and then unmarshalling the JSON into the corresponding Go struct.The existing parser for the V2 format has been preserved to handle older data formats.
Additionally, comprehensive tests for the new V3 parsing logic have been added to ensure correctness. The V3 tests, where real data is fetched, are currently skipped as the v3.0.0 release is not yet available.
Taken from #1635