feat(monitoring): Add failure alerts for Cloud Run jobs #1894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new monitoring alert policy for Cloud Run jobs managed by the single_stage_go_workflow module. The alert will fire with an "ERROR" severity if a job execution fails and there are no successful executions for that job within a 23-hour period. This helps to proactively detect and respond to persistent job failures and we don't have to rely on the existing dashboard. To support this, a notification_channel_ids variable has been added and plumbed through the Terraform configuration to specify where alerts should be sent. Additionally, this commit includes the following changes: - Adds a tf-lint command to the Makefile to validate Terraform configurations. - Removes the unused workflows/web-features-repo/workflows.yaml.tftpl file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new monitoring alert policy for Cloud Run jobs managed by the single_stage_go_workflow module.
The alert will fire with an "ERROR" severity if a job execution fails and there are no successful executions for that job within a 23-hour period. This helps to proactively detect and respond to persistent job failures and we don't have to rely on the existing dashboard.
To support this, a notification_channel_ids variable has been added and plumbed through the Terraform configuration to specify where alerts should be sent.
Additionally, this commit includes the following changes: