Add storage pool blueprints and integration tests for VM, GKE, and Slurm

[rahimkhan19]

This PR introduces blueprints and integration tests for GCP Storage Pools across : VM, GKE, and Slurm.

Key Changes:

• VM Storage:
  • Added a new storage-vm.yaml blueprint with a complete Cloud Build pipeline.
  • Added an Ansible integration test (test-vm-storage.yml) to verify persistent disks are securely placed in target Hyperdisk storage pools.
• GKE Storage:
  • Upgraded the storage-gke.yaml blueprint and CI pipeline to strictly assert Hyperdisk storage pool placement through dynamically provisioned PVs.
• Slurm Storage:
  • Renamed the legacy rapid-storage-slurm.yaml to storage-slurm.yaml.
  • Added Ansible validations to ensure slurm-nodeset, login, and controller instance templates are bound to the correct pools.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the GCP storage configuration by introducing standardized blueprints and automated integration tests for Hyperdisk storage pools across VM, GKE, and Slurm environments. These changes ensure that persistent disks are correctly provisioned and bound to the intended storage pools, improving infrastructure reliability and verification within the CI/CD pipeline.

Highlights

• VM Storage Support: Added a new storage-vm.yaml blueprint and corresponding Ansible integration tests to verify persistent disk placement in Hyperdisk storage pools.
• GKE Storage Enhancements: Updated the storage-gke.yaml blueprint to enforce Hyperdisk storage pool placement and added automated validation tests for dynamically provisioned PVs.
• Slurm Storage Refactoring: Renamed legacy Slurm storage blueprints to storage-slurm.yaml and implemented Ansible validations to ensure node and controller instance templates are correctly bound to storage pools.
• CI/CD Pipeline Updates: Integrated storage pool verification into Cloud Build daily test pipelines for VM, GKE, and Slurm environments, including automated existence checks for required pools.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces storage pool configurations (balanced and throughput) across GKE, Slurm, and VM example blueprints, along with corresponding integration tests and validation playbooks. A high-severity issue was identified in the Slurm storage validation playbook (test-slurm-storage.yml), where the controller's additional disk name is incorrectly hardcoded as slurm_controller-data instead of being dynamically prefixed with the cluster name, which will cause the integration test to fail.

[rahimkhan19]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces support for Hyperdisk storage pools across GKE, Slurm, and VM examples, including new validation tests and Cloud Build configurations to verify correct disk placement. The review feedback recommends updating the examples/README.md index to document the new storage-vm.yaml blueprint and the renamed storage-slurm.yaml blueprint, in accordance with the repository style guide. Additionally, it is suggested to remove a redundant 15-second pause in the GKE storage pool validation test to optimize test execution time.