Skip to content

feat(testing): cut over daily test suite to Kueue scheduling - #6151

Open
sudheer-quad wants to merge 1 commit into
GoogleCloudPlatform:developfrom
sudheer-quad:migration/kueue-gke-a3h-a3m-v6e-tests
Open

feat(testing): cut over daily test suite to Kueue scheduling#6151
sudheer-quad wants to merge 1 commit into
GoogleCloudPlatform:developfrom
sudheer-quad:migration/kueue-gke-a3h-a3m-v6e-tests

Conversation

@sudheer-quad

Copy link
Copy Markdown
Contributor

This PR transitions the gke scheduler tests suite of GPU a3h, a3m and TPU v6e instances to Kueue scheduling in the hpc-toolkit-dev-2 project.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@github-actions github-actions Bot added the external PR from external contributor label Aug 14, 2026
@sudheer-quad sudheer-quad added the release-chore To not include into release notes label Aug 14, 2026
@sudheer-quad sudheer-quad self-assigned this Aug 14, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request transitions the GKE daily test suites for A3 high-GPU, A3 mega-GPU, and TPU v6e instances to use Kueue for job scheduling. This migration leverages Kubernetes-native job queuing to enhance resource management, improve test reliability, and provide better visibility into job execution within the HPC toolkit development environment.

Highlights

  • Kueue Migration: Migrated GKE daily test suites for A3 high-GPU, A3 mega-GPU, and TPU v6e instances to use Kueue for job scheduling.
  • Build Pipeline Updates: Updated build configurations to include automated job manifest generation, Kueue job submission, and robust monitoring with retry logic.
  • Resource Management: Added cleanup steps for container images and infrastructure resources to optimize costs and prevent resource leaks.
  • Configuration Tracking: Updated Terraform variables and documentation to track the migration of these test suites to the Kueue scheduling system.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the gke-a3-highgpu-onspot, gke-a3-megagpu-onspot, and gke-tpu-v6e daily tests to run as GKE Kueue jobs, updating the provisioning configuration and documentation accordingly. Feedback on these changes highlights a critical issue where sourcing wait_for_available_zone.sh clears the cleanup_pod trap, which could lead to leaked cloud resources upon failure; re-registering the trap immediately after sourcing is recommended. Additionally, backup files (*_old.yaml.bak) should be removed from the repository before merging.

Comment thread tools/cloud-build/daily-tests/builds/gke-a3-highgpu-onspot.yaml
Comment thread tools/cloud-build/daily-tests/builds/gke-a3-megagpu-onspot.yaml
Comment thread tools/cloud-build/daily-tests/builds/gke-tpu-v6e.yaml
Comment thread tools/cloud-build/daily-tests/builds/gke-tpu-v6e_old.yaml.bak
@sudheer-quad
sudheer-quad marked this pull request as ready for review August 17, 2026 06:37
@sudheer-quad
sudheer-quad requested a review from a team as a code owner August 17, 2026 06:37
@sudheer-quad
sudheer-quad requested review from saara-tyagi27 and shivam222 and removed request for saara-tyagi27 and shivam222 August 17, 2026 06:37

@rahimkhan19 rahimkhan19 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants