feat(testing): cut over daily test suite to Kueue scheduling - #6151
feat(testing): cut over daily test suite to Kueue scheduling#6151sudheer-quad wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request transitions the GKE daily test suites for A3 high-GPU, A3 mega-GPU, and TPU v6e instances to use Kueue for job scheduling. This migration leverages Kubernetes-native job queuing to enhance resource management, improve test reliability, and provide better visibility into job execution within the HPC toolkit development environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request migrates the gke-a3-highgpu-onspot, gke-a3-megagpu-onspot, and gke-tpu-v6e daily tests to run as GKE Kueue jobs, updating the provisioning configuration and documentation accordingly. Feedback on these changes highlights a critical issue where sourcing wait_for_available_zone.sh clears the cleanup_pod trap, which could lead to leaked cloud resources upon failure; re-registering the trap immediately after sourcing is recommended. Additionally, backup files (*_old.yaml.bak) should be removed from the repository before merging.
This PR transitions the gke scheduler tests suite of GPU a3h, a3m and TPU v6e instances to Kueue scheduling in the hpc-toolkit-dev-2 project.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.