fix(telemetry): unify duplicate Stockout error categories

[ishitachail]

Consolidation of Error Categories: Removed the redundant 'ErrTypeExtraStockout' constant and unified all related error matching logic to use 'ErrTypeStockout'.
Telemetry Update: Updated error matchers and unit tests to reflect the consolidated 'ErrTypeStockout' category, ensuring consistent telemetry reporting.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

• Fork your PR branch from the Toolkit "develop" branch (not main)
• Test all changes with pre-commit in a local branch #
• Confirm that "make tests" passes all tests
• Add or modify unit tests to cover code changes
• Ensure that unit test coverage remains above 80%
• Update all applicable documentation
• Follow Cluster Toolkit Contribution guidelines #

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request simplifies the telemetry error categorization by merging duplicate stockout error types into a single, unified category. This change improves maintainability and consistency in how resource unavailability errors are tracked across the system.

Highlights

• Consolidation of Error Categories: Removed the redundant 'ErrTypeExtraStockout' constant and unified all related error matching logic to use 'ErrTypeStockout'.
• Telemetry Update: Updated error matchers and unit tests to reflect the consolidated 'ErrTypeStockout' category, ensuring consistent telemetry reporting.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request unifies ErrTypeExtraStockout into ErrTypeStockout by removing the redundant constant and updating the corresponding test cases and error matchers. The reviewer suggested removing three now-redundant substring matchers whose patterns are already covered by broader matchers mapping to the same error type, which simplifies the codebase.