feat(make): add make install-csi, make uninstall-csi, and ARGS support for make e2e-test - #5028
feat(make): add make install-csi, make uninstall-csi, and ARGS support for make e2e-test#5028meet2mky wants to merge 2 commits into
make install-csi, make uninstall-csi, and ARGS support for make e2e-test#5028Conversation
…e GCS FUSE CSI driver on GKE clusters
There was a problem hiding this comment.
Code Review
This pull request introduces helper targets and scripts (install-csi and uninstall-csi) to manage the installation and uninstallation of the Cloud Storage FUSE CSI driver on GKE clusters, along with a detailed help target in the Makefile. Feedback on these changes highlights potential issues with the removal of automatic zone/region retrieval in the e2e-test target, and recommends wrapping the interactive confirmation prompts in both scripts with a TTY check to prevent failures in non-interactive CI/CD environments.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5028 +/- ##
==========================================
+ Coverage 83.90% 83.92% +0.02%
==========================================
Files 176 176
Lines 21546 21546
==========================================
+ Hits 18078 18083 +5
+ Misses 2769 2766 -3
+ Partials 699 697 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi @kislaykishore, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
…ning in non-terminal environments
Description
This PR introduces Makefile targets and helper scripts to streamline installing and uninstalling custom builds of the Cloud Storage FUSE CSI driver on target GKE clusters, as well as enabling argument forwarding to integration tests.
Key Changes
CSI Driver Installation & Management:
make install-csiandtools/scripts/install_csi.sh:CLUSTER_PROJECT,CLUSTER_NAME, andCLUSTER_LOCATIONfrom the activekubectlcontext (with manual CLI override support).prow-gob-internal-boskos-csi-${CSI_COMMIT_SHA}-fuse-${GCSFUSE_COMMIT_SHA}.gcs-fuse-csi-driver, builds multi-arch container images from source, pushes to Artifact Registry, and installs manifests.Driver,Sidecar Mounter,Webhook,Metadata Prefetch).make uninstall-csiandtools/scripts/uninstall_csi.sh:Integration Test Improvements:
make e2e-testto forward arguments directly toimproved_run_e2e_tests.shvia theARGSvariable (e.g.make e2e-test ARGS="--run-package streaming_writes --skip-emulator").Documentation & Help:
make helpto document all targets, active defaults, and configurable parameters.Testing
make install-csion GKE test cluster (mohitkyadav-clusteringcs-fuse-test):gcs-fuse-csi-drivernamespace (controller, webhook, and node daemonsets across 20 nodes) reachRunningstate.make uninstall-csiclean resource deletion.make e2e-test ARGS="--help"and argument forwarding.