-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(genai): add samples for embeddings, provisioned throughput and safety #10188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(genai): add samples for embeddings, provisioned throughput and safety #10188
Conversation
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @jdomingr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the GenAI SDK's sample collection by introducing three new Java examples. These additions provide developers with practical demonstrations for leveraging text embeddings in document retrieval, optimizing content generation through provisioned throughput, and implementing robust safety controls to manage potentially harmful outputs. The goal is to streamline the integration of advanced GenAI capabilities into various applications. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds three new GenAI samples for embeddings, provisioned throughput, and safety settings, along with their corresponding integration tests. The changes are generally good, but I've found a couple of areas for improvement. Specifically, the provisioned throughput sample uses an incorrect setting, which makes it misleading. I've also pointed out a magic number in the embeddings sample that could be refactored for better maintainability. The safety settings sample and all the tests look good.
genai/snippets/src/main/java/genai/provisionedthroughput/ProvisionedThroughputWithTxt.java
Show resolved
Hide resolved
genai/snippets/src/main/java/genai/embeddings/EmbeddingsDocRetrievalWithTxt.java
Show resolved
Hide resolved
|
LGTM |
Add new genai samples:
Checklist
mvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only