-
Notifications
You must be signed in to change notification settings - Fork 2k
fix(functions): update and fix functions_billing_stop
sample
#4085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
iennae
merged 19 commits into
main
from
paradalicea/fix/functions/sample-billing-stop/b-403855924
Aug 1, 2025
Merged
Changes from 16 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
24c71f9
fix(functions): update and fix `functions_billing_stop` sample
eapl-gemugami 5863455
fix(functions): add a variable for the developer to simulate disablin…
eapl-gemugami a4712e5
Merge branch 'main' into paradalicea/fix/functions/sample-billing-sto…
iennae e77736c
Merge branch 'main' into paradalicea/fix/functions/sample-billing-sto…
iennae 2e87396
fix(functions): stop-billing - update dependencies to latest versions
eapl-gemugami 96a8334
fix(functions): stop-billing-cloud-event - WIP Implement sample
eapl-gemugami 6f98466
fix(functions): stop-billing - clean up unused files
eapl-gemugami c1a36d5
fix(functions): fix stop-billing sample
eapl-gemugami 8505f6a
Merge branch 'main' into paradalicea/fix/functions/sample-billing-sto…
eapl-gemugami bb58b19
fix(functions): stop-billing - Apply feedback from gemini-code-assist…
eapl-gemugami 82d6db3
fix(functions): stop-billing - Add support for ECMAScript 2020 to the…
eapl-gemugami e6ab704
fix(functions): stop-billing - Apply feedback from gemini-code-assist…
eapl-gemugami b279adf
fix(functions): stop-billing - Apply freedback from gemini-code-assis…
eapl-gemugami 3c6c473
fix(functions): stop-billing - Apply feedback from glasnt https://git…
eapl-gemugami 5f7f27d
fix(functions): stop-billing - Apply feedback from glasnt https://git…
eapl-gemugami d1cb382
Merge branch 'main' into paradalicea/fix/functions/sample-billing-sto…
eapl-gemugami 99920e2
fix(functions): stopBilling - Move sample from root folder to v2, sin…
eapl-gemugami ebefd6e
fix(functions): stopBilling - Update info message on dryRun mode.
eapl-gemugami 57984ef
Merge branch 'main' into paradalicea/fix/functions/sample-billing-sto…
iennae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"parserOptions": { | ||
"ecmaVersion": 2020 | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,136 @@ | ||
// Copyright 2025 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
// [START functions_billing_stop] | ||
const {CloudBillingClient} = require('@google-cloud/billing'); | ||
const functions = require('@google-cloud/functions-framework'); | ||
const gcpMetadata = require('gcp-metadata'); | ||
|
||
const billing = new CloudBillingClient(); | ||
|
||
let projectId = process.env.GOOGLE_CLOUD_PROJECT; | ||
|
||
// TODO(developer): Since stopping billing is a destructive action | ||
// for your project, first validate a test budget with a dry run enabled. | ||
const dryRun = true; | ||
|
||
functions.cloudEvent('StopBillingCloudEvent', async cloudEvent => { | ||
if (projectId === undefined) { | ||
try { | ||
projectId = await gcpMetadata.project('project-id'); | ||
glasnt marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} catch (error) { | ||
console.error('project-id metadata not found:', error); | ||
|
||
console.error( | ||
'Project ID could not be found in environment variables ' + | ||
'or Cloud Run metadata server. Stopping execution.' | ||
); | ||
return; | ||
} | ||
} | ||
|
||
const projectName = `projects/${projectId}`; | ||
|
||
// Find more information about the notification format here: | ||
// https://cloud.google.com/billing/docs/how-to/budgets-programmatic-notifications#notification-format | ||
const messageData = cloudEvent.data?.message?.data; | ||
if (!messageData) { | ||
console.error('Invalid CloudEvent: missing data.message.data'); | ||
return; | ||
} | ||
|
||
const eventData = Buffer.from(messageData, 'base64').toString(); | ||
|
||
let eventObject; | ||
try { | ||
eventObject = JSON.parse(eventData); | ||
} catch (e) { | ||
console.error('Error parsing event data:', e); | ||
return; | ||
} | ||
|
||
console.log( | ||
`Project ID: ${projectId} ` + | ||
`Current cost: ${eventObject.costAmount} ` + | ||
`Budget: ${eventObject.budgetAmount}` | ||
eapl-gemugami marked this conversation as resolved.
Show resolved
Hide resolved
|
||
); | ||
|
||
if (eventObject.costAmount <= eventObject.budgetAmount) { | ||
console.log('No action required. Current cost is within budget.'); | ||
return; | ||
} | ||
|
||
console.log(`Disabling billing for project '${projectName}'...`); | ||
|
||
const billingEnabled = await _isBillingEnabled(projectName); | ||
if (billingEnabled) { | ||
await _disableBillingForProject(projectName); | ||
} else { | ||
console.log('Billing is already disabled.'); | ||
} | ||
}); | ||
|
||
/** | ||
* Determine whether billing is enabled for a project | ||
* @param {string} projectName The name of the project to check | ||
* @returns {boolean} Whether the project has billing enabled or not | ||
*/ | ||
const _isBillingEnabled = async projectName => { | ||
try { | ||
console.log(`Getting billing info for project '${projectName}'...`); | ||
const [res] = await billing.getProjectBillingInfo({name: projectName}); | ||
|
||
return res.billingEnabled; | ||
} catch (e) { | ||
console.error('Error getting billing info:', e); | ||
console.error( | ||
'Unable to determine if billing is enabled on specified project, ' + | ||
'assuming billing is enabled' | ||
); | ||
|
||
return true; | ||
} | ||
}; | ||
|
||
/** | ||
* Disable billing for a project by removing its billing account | ||
* @param {string} projectName The name of the project to disable billing | ||
* @returns {void} | ||
*/ | ||
const _disableBillingForProject = async projectName => { | ||
if (dryRun) { | ||
console.log( | ||
'** This script would disable billing here, but "dryRun" has been set to true.' + | ||
|
||
'Change "dryRun" to alter this behaviour.' | ||
); | ||
return; | ||
} | ||
|
||
// Find more information about `projects/updateBillingInfo` API method here: | ||
// https://cloud.google.com/billing/docs/reference/rest/v1/projects/updateBillingInfo | ||
try { | ||
// To disable billing set the `billingAccountName` field to empty | ||
const requestBody = {billingAccountName: ''}; | ||
|
||
const [response] = await billing.updateProjectBillingInfo({ | ||
name: projectName, | ||
resource: requestBody, | ||
}); | ||
|
||
console.log(`Billing disabled. Response: ${JSON.stringify(response)}`); | ||
} catch (e) { | ||
console.error('Failed to disable billing, check permissions.', e); | ||
} | ||
}; | ||
// [END functions_billing_stop] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
{ | ||
"name": "cloud-functions-stop-billing", | ||
"private": true, | ||
"version": "0.0.1", | ||
"description": "Disable billing with a budget notification.", | ||
"main": "index.js", | ||
"engines": { | ||
"node": ">=20.0.0" | ||
}, | ||
"scripts": { | ||
"test": "c8 mocha -p -j 2 test/index.test.js --timeout=5000 --exit" | ||
}, | ||
"author": "Google Inc.", | ||
"license": "Apache-2.0", | ||
"dependencies": { | ||
"@google-cloud/billing": "^5.1.0", | ||
"@google-cloud/functions-framework": "^4.0.0", | ||
"cloudevents": "^10.0.0", | ||
"gcp-metadata": "^7.0.1" | ||
}, | ||
"devDependencies": { | ||
"c8": "^10.1.3" | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,121 @@ | ||
// Copyright 2025 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
const assert = require('assert'); | ||
const {CloudEvent} = require('cloudevents'); | ||
const {getFunction} = require('@google-cloud/functions-framework/testing'); | ||
|
||
require('../index'); | ||
|
||
const getDataWithinBudget = () => { | ||
return { | ||
budgetDisplayName: 'BUDGET_NAME', | ||
costAmount: 5.0, | ||
costIntervalStart: new Date().toISOString(), | ||
budgetAmount: 10.0, | ||
budgetAmountType: 'SPECIFIED_AMOUNT', | ||
currencyCode: 'USD', | ||
}; | ||
}; | ||
|
||
const getDataOverBudget = () => { | ||
return { | ||
budgetDisplayName: 'BUDGET_NAME', | ||
alertThresholdExceeded: 0.9, | ||
costAmount: 20.0, | ||
costIntervalStart: new Date().toISOString(), | ||
budgetAmount: 10.0, | ||
budgetAmountType: 'SPECIFIED_AMOUNT', | ||
currencyCode: 'USD', | ||
}; | ||
}; | ||
|
||
/** | ||
* Get a simulated CloudEvent for a Budget notification. | ||
* Find more examples here: | ||
* https://cloud.google.com/billing/docs/how-to/budgets-programmatic-notifications | ||
* @param {boolean} isOverBudget - Whether or not the budget has been exceeded. | ||
* @returns {CloudEvent} The simulated CloudEvent. | ||
*/ | ||
const getCloudEventOverBudgetAlert = isOverBudget => { | ||
let budgetData; | ||
|
||
if (isOverBudget) { | ||
budgetData = getDataOverBudget(); | ||
} else { | ||
budgetData = getDataWithinBudget(); | ||
} | ||
|
||
const jsonString = JSON.stringify(budgetData); | ||
const messageBase64 = Buffer.from(jsonString).toString('base64'); | ||
|
||
const encodedData = { | ||
message: { | ||
data: messageBase64, | ||
}, | ||
}; | ||
|
||
return new CloudEvent({ | ||
specversion: '1.0', | ||
id: 'my-id', | ||
source: '//pubsub.googleapis.com/projects/PROJECT_NAME/topics/TOPIC_NAME', | ||
data: encodedData, | ||
type: 'google.cloud.pubsub.topic.v1.messagePublished', | ||
datacontenttype: 'application/json', | ||
time: new Date().toISOString(), | ||
}); | ||
}; | ||
|
||
describe('index.test.js', () => { | ||
describe('functions_billing_stop StopBillingCloudEvent', () => { | ||
let consoleOutput = ''; | ||
const originalConsoleLog = console.log; | ||
const originalConsoleError = console.error; | ||
|
||
beforeEach(async () => { | ||
consoleOutput = ''; | ||
console.log = message => (consoleOutput += message + '\n'); | ||
console.error = message => (consoleOutput += 'ERROR: ' + message + '\n'); | ||
}); | ||
|
||
afterEach(() => { | ||
console.log = originalConsoleLog; | ||
console.error = originalConsoleError; | ||
}); | ||
|
||
it('should receive a notification within budget', async () => { | ||
const StopBillingCloudEvent = getFunction('StopBillingCloudEvent'); | ||
const isOverBudget = false; | ||
await StopBillingCloudEvent(getCloudEventOverBudgetAlert(isOverBudget)); | ||
|
||
assert.ok( | ||
consoleOutput.includes( | ||
'No action required. Current cost is within budget.' | ||
) | ||
); | ||
}); | ||
|
||
it('should receive a notification exceeding the budget and simulate stopping billing', async () => { | ||
const StopBillingCloudEvent = getFunction('StopBillingCloudEvent'); | ||
const isOverBudget = true; | ||
await StopBillingCloudEvent(getCloudEventOverBudgetAlert(isOverBudget)); | ||
|
||
assert.ok(consoleOutput.includes('Getting billing info')); | ||
assert.ok(consoleOutput.includes('Disabling billing for project')); | ||
assert.ok( | ||
consoleOutput.includes('This script would disable billing here') | ||
); | ||
}); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.