-
Notifications
You must be signed in to change notification settings - Fork 2k
fix(text-generation): update Gemini model version #4135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(text-generation): update Gemini model version #4135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @laxmi-genai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on updating the Gemini model version used in a specific Node.js text generation sample. The core intent is to maintain consistency with the latest documentation and other SDK examples, providing users with an accurate and up-to-date quickstart experience when interacting with the Gemini API.
Highlights
- Model Version Update: The
gemini-2.0-flash
model has been updated togemini-2.5-flash
in thetextgen-with-txt.js
sample. - Documentation Alignment: This change ensures the Node.js sample aligns with the model version referenced in the official Vertex AI Generative AI documentation and the Python SDK examples, improving consistency for users.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the Gemini model version from gemini-2.0-flash
to gemini-2.5-flash
in the NodeJS text generation sample. The change is straightforward and aligns with the goal stated in the description. I have provided one suggestion to improve maintainability by extracting the hardcoded model name into a constant, which is a common best practice.
Description
Update to gemini-2.5-flash from gemini-2.0-flash. This file is referenced in https://cloud.google.com/vertex-ai/generative-ai/docs/start/quickstart?usertype=adc#googlegenaisdk_textgen_with_txt-nodejs_genai_sdk and the Python SDK example refers to gemini-2.5-flash. Submitting this PR so that the NodeJS code has the same version
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.